Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ASCII rectangles on pkgdown are off #83

Open
krlmlr opened this issue Aug 20, 2024 · 6 comments
Open

ASCII rectangles on pkgdown are off #83

krlmlr opened this issue Aug 20, 2024 · 6 comments

Comments

@krlmlr
Copy link
Member

krlmlr commented Aug 20, 2024

README: https://github.com/tidyverse/duckplyr/?tab=readme-ov-file#usage-for-individual-data-frames

Website: https://duckplyr.tidyverse.org/#usage-for-individual-data-frames

Scroll down a bit.

@krlmlr
Copy link
Member Author

krlmlr commented Aug 20, 2024

In Firefox I see:

image

@krlmlr
Copy link
Member Author

krlmlr commented Aug 21, 2024

@maelle: Any idea? This is Firefox only, Safari is better. No idea about other browsers.

@maelle
Copy link
Contributor

maelle commented Aug 21, 2024

To make things worse, it looks good for me on Firefox on Ubuntu

image

@hadley
Copy link
Member

hadley commented Aug 21, 2024

My investigation notes at pola-rs/polars#18187 (comment)

@maelle
Copy link
Contributor

maelle commented Oct 7, 2024

@krlmlr
Copy link
Member Author

krlmlr commented Oct 7, 2024

It's not the same style. I've worked around with plain dashes for now, I'd rather fix for good or keep it as is.

When I inspect the code chunk, I see "Font Awesome 6" being mentioned. Is this the same as "Source Code Pro"?

Would it help if we served a more complete version of "Source Code Pro", if google/fonts#4235 turns out to be the issue?

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants