From 664737a259b5dfa6be383f23290434cf3014a5ad Mon Sep 17 00:00:00 2001 From: Andrea Ranzato Date: Wed, 26 Mar 2025 14:53:04 +0100 Subject: [PATCH 1/3] feat: Hard deprecate 'data_frame()' --- R/deprecated.R | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/R/deprecated.R b/R/deprecated.R index ac088bf49..28fd1a66b 100644 --- a/R/deprecated.R +++ b/R/deprecated.R @@ -9,7 +9,7 @@ #' @keywords internal #' @name deprecated data_frame <- function(...) { - deprecate_warn("1.1.0", "data_frame()", "tibble()") + deprecate_stop("1.1.0", "data_frame()", "tibble()") # Unquote-splice to avoid argument matching tibble(!!!quos(...)) From 1c4db1854671362564b9df0363e7856c6335a7cb Mon Sep 17 00:00:00 2001 From: Andrea Ranzato Date: Wed, 26 Mar 2025 15:03:59 +0100 Subject: [PATCH 2/3] chore: Bump pkg version in hard deprecation msg --- R/deprecated.R | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/R/deprecated.R b/R/deprecated.R index 28fd1a66b..c19352bf9 100644 --- a/R/deprecated.R +++ b/R/deprecated.R @@ -9,7 +9,7 @@ #' @keywords internal #' @name deprecated data_frame <- function(...) { - deprecate_stop("1.1.0", "data_frame()", "tibble()") + deprecate_stop("3.3.0", "data_frame()", "tibble()") # Unquote-splice to avoid argument matching tibble(!!!quos(...)) From 1cfc7fc0bfff822375284c49554920741bf4f8b1 Mon Sep 17 00:00:00 2001 From: Andrea Ranzato Date: Wed, 26 Mar 2025 16:31:58 +0100 Subject: [PATCH 3/3] feat: Improve deprecation message --- R/deprecated.R | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/R/deprecated.R b/R/deprecated.R index c19352bf9..52ad3323e 100644 --- a/R/deprecated.R +++ b/R/deprecated.R @@ -9,7 +9,7 @@ #' @keywords internal #' @name deprecated data_frame <- function(...) { - deprecate_stop("3.3.0", "data_frame()", "tibble()") + deprecate_stop("3.3.0", "data_frame()", details = 'Please use `tibble()` to create a tibble and `vctrs::data_frame()` to create a data frame.') # Unquote-splice to avoid argument matching tibble(!!!quos(...))