Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve documentation for rows_insert() vs rows_append() #6864

Open
mgirlich opened this issue Jun 6, 2023 · 2 comments
Open

Improve documentation for rows_insert() vs rows_append() #6864

mgirlich opened this issue Jun 6, 2023 · 2 comments
Labels
documentation rows ↕️ Operations on rows: filter(), slice(), arrange()

Comments

@mgirlich
Copy link

mgirlich commented Jun 6, 2023

It seems that people easily confuse what rows_insert() is for and use it when they actually need rows_append() (e.g. tidyverse/dbplyr#1297 or tidyverse/dbplyr#1149). It would be nice to improve the documentation (or maybe even the names) of rows_insert() and rows_append() to make it more clear when to use which function.

@wdenton
Copy link

wdenton commented Jun 6, 2023

As the creator of tidyverse/dbplyr#1297, I suggest one point that would help is a mention or example of how to add a row to a table that might have some duplicated data while not permitting a complete duplicate. If rows_insert() means everything added has to be unique, and rows_append() allows creating the same row over and over (except for the automatically created primary key, that is), then is there a dbplyr way in my example to add a green apple, without defining a primary key and without resorting to a lot of SQL? Having that in the docs would be a big help.

Thanks for noting this, and for all the excellent work on dbplyr.

@hsalberti
Copy link

Approached this issue here!
#6942

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation rows ↕️ Operations on rows: filter(), slice(), arrange()
Projects
None yet
Development

No branches or pull requests

4 participants