Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Granular .drop argument? #4129

Closed
lionel- opened this issue Jan 25, 2019 · 1 comment
Closed

Granular .drop argument? #4129

lionel- opened this issue Jan 25, 2019 · 1 comment
Labels
feature a feature request or enhancement grouping 👨‍👩‍👧‍👦
Milestone

Comments

@lionel-
Copy link
Member

lionel- commented Jan 25, 2019

My first expectation would have been that .drop only applies for specific variables, i.e. in the following a and b would still keep their groups:

data %>% group_by(a, b, .drop = FALSE) %>% group_by(c, .drop = TRUE)

Since creating empty groups is expensive, a more granular drop attribute might be useful.

Originally posted by @lionel- in #4091

@romainfrancois romainfrancois added this to the 0.9.0 milestone Jan 30, 2019
@hadley hadley added feature a feature request or enhancement grouping 👨‍👩‍👧‍👦 labels Dec 11, 2019
@hadley
Copy link
Member

hadley commented Jan 22, 2020

I think we'll solve this by allowing the user to supply their own grouping data frame, which we're tracking in #4722

@hadley hadley closed this as completed Jan 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature a feature request or enhancement grouping 👨‍👩‍👧‍👦
Projects
None yet
Development

No branches or pull requests

3 participants