Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backend-* spring cleaning for erroring code #1546

Open
2 of 4 tasks
simonpcouch opened this issue Oct 21, 2024 · 0 comments
Open
2 of 4 tasks

backend-* spring cleaning for erroring code #1546

simonpcouch opened this issue Oct 21, 2024 · 0 comments

Comments

@simonpcouch
Copy link
Collaborator

simonpcouch commented Oct 21, 2024

Will start out with just one backend as a demo, but imagining one PR per checkbox here (applying to all backends, rather than one PR per backend with all of the following complete in each. Happy to adjust here.):

  • audit calls to expect_error() for backend-*.R files #1552
    • ...to snapshot when testing the error message
    • ...to classed error when testing an error from another package or an error thrown from a widely-used helper
    • ...to expect_no_error() (or no test) when regex = NA
    • Analogous story for expect_warning() and expect_message().
  • Use type checkers #1555
  • Transition erroring code to cli
    • Update snapshots
  • Test untested erroring code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant