Skip to content
This repository has been archived by the owner on May 13, 2024. It is now read-only.

Swift4 compile warnings #118

Open
chadham opened this issue Mar 24, 2018 · 1 comment · May be fixed by #122
Open

Swift4 compile warnings #118

chadham opened this issue Mar 24, 2018 · 1 comment · May be fixed by #122

Comments

@chadham
Copy link

chadham commented Mar 24, 2018

1027 var path = CFURLCopyPath(req.url! as CFURL!) as String
//Using '!' in this location is deprecated and will be removed in a future release; consider changing this to '?' instead

1061 CFStreamCreatePairWithSocketToHost(nil, addr[0] as CFString!, UInt32(Int(addr[1])!), &readStream, &writeStream);
//; is not needed //Using '!' in this location is deprecated and will be removed in a future release; consider changing this to '?' instead

1147 key = trim(line.substring(to: r.lowerBound))
// 'substring(to:)' is deprecated: Please use String slicing subscript with a 'partial range upto' operator.

1148 value = trim(line.substring(from: r.upperBound))
//'substring(from:)' is deprecated: Please use String slicing subscript with a 'partial range from' operator.

@moozzyk moozzyk linked a pull request Apr 22, 2018 that will close this issue
moozzyk added a commit to moozzyk/SignalR-Client-Swift that referenced this issue Apr 22, 2018
This is because of tidwall/SwiftWebSocket#118 which prevents porjects depending on SwiftWebSocket from being pushed to CocoaPods

Opened tidwall/SwiftWebSocket#122. Once the PR is merged and a new version is released this change should be reversed.
@yusufonderd
Copy link

I'm facing same issue.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants