From 50d8604ea40b4c2aacb55ee1128a2706f421715c Mon Sep 17 00:00:00 2001 From: Abdullah Al-Faqeir Date: Tue, 17 Sep 2024 10:26:35 +0300 Subject: [PATCH] chore(android): gradle 8 (#14014) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * chore(android): let there be gradle 8 chore(android): fixed deprecations in kroll-apt project chore(android): made kroll-apt incremental to enhance build time * fix(android): revert change to java files fix(android): gradle 8 compatibility update to template build.gradle fix(android): revert dependency updates fix(android): revert minSdk and targetSdk * fix(android): kitchensink-app not running after gradle 8 fix(android): update _build.js & _buildModule.js for new gradle * Update android/app/build.gradle Co-authored-by: Chris Barber * Update android/templates/build/ti.constants.gradle Co-authored-by: Chris Barber * Update android/titanium/build.gradle Co-authored-by: Chris Barber * Update android/titanium/build.gradle Co-authored-by: Chris Barber * Update android/untar.gradle Co-authored-by: Chris Barber * Update android/titanium/build.gradle Co-authored-by: Chris Barber * fix material.r * github action * optimize material imports * optimize material imports * fix(android): fix module building * fix(android): bump ndk version for generated modules --------- Co-authored-by: Hans Knöchel Co-authored-by: Chris Barber Co-authored-by: Michael Gangolf Co-authored-by: Michael Gangolf --- .github/workflows/build.yml | 12 +- .github/workflows/release.yml | 10 +- android/.gitignore | 1 + android/.idea/codeStyles/Project.xml | 3 + android/app/build.gradle | 14 +- android/build.gradle | 8 +- android/cli/commands/_build.js | 6 +- android/cli/commands/_buildModule.js | 6 - android/gradle.properties | 3 - .../gradle/wrapper/gradle-wrapper.properties | 3 +- android/kroll-apt/build.gradle | 7 +- .../generator/KrollJSONGenerator.java | 2 +- .../gradle/incremental.annotation.processors | 1 + .../ti/modules/titanium/ui/PickerProxy.java | 2 +- .../titanium/ui/widget/TiImageView.java | 2 +- .../ui/widget/TiUIActivityIndicator.java | 2 +- .../titanium/ui/widget/TiUIButton.java | 2 +- .../titanium/ui/widget/TiUIButtonBar.java | 4 +- .../titanium/ui/widget/TiUIOptionBar.java | 12 +- .../titanium/ui/widget/TiUITabbedBar.java | 2 +- .../modules/titanium/ui/widget/TiUIText.java | 2 +- .../widget/listview/TiRecyclerViewHolder.java | 5 +- .../ui/widget/searchbar/TiUISearchBar.java | 2 +- .../widget/tabgroup/TiUIAbstractTabGroup.java | 2 +- android/settings.gradle | 4 +- android/templates/build/AndroidManifest.xml | 1 - android/templates/build/app.build.gradle | 8 +- android/templates/build/root.build.gradle | 7 +- android/templates/build/ti.constants.gradle | 3 +- .../templates/module/generated/build.gradle | 33 ++-- android/titanium/AndroidManifest.xml | 27 +-- android/titanium/build.gradle | 162 +++++++++++------- android/untar.gradle | 72 ++++---- 33 files changed, 238 insertions(+), 192 deletions(-) create mode 100644 android/kroll-apt/src/main/resources/META-INF/gradle/incremental.annotation.processors diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index f0c0afcb02d..7ee41f0c410 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -21,8 +21,8 @@ jobs: - name: Android build uses: ./.github/actions/build-android with: - node-version: '16.x' - java-version: '11' + node-version: '18.x' + java-version: '17' ios: runs-on: macos-13 @@ -39,7 +39,7 @@ jobs: - name: iOS build uses: ./.github/actions/build-ios with: - node-version: '16.x' + node-version: '18.x' js: runs-on: ubuntu-latest @@ -50,10 +50,10 @@ jobs: with: fetch-depth: 0 - - name: Use Node.js 16.x + - name: Use Node.js uses: actions/setup-node@v3 with: - node-version: '16.x' + node-version: '18.x' cache: 'npm' - name: Install dependencies @@ -84,5 +84,5 @@ jobs: uses: ./.github/actions/package with: node-version: '16.x' - java-version: '11' + java-version: '17' vtag: ${{ env.vtag }} diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 9ab7e263666..120c547b08c 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -77,8 +77,8 @@ jobs: - name: Android build uses: ./.github/actions/build-android with: - node-version: '16.x' - java-version: '11' + node-version: '18.x' + java-version: '17' ios: runs-on: macos-13 @@ -97,7 +97,7 @@ jobs: - name: iOS build uses: ./.github/actions/build-ios with: - node-version: '16.x' + node-version: '18.x' package: runs-on: macos-12 @@ -116,8 +116,8 @@ jobs: - name: Package uses: ./.github/actions/package with: - node-version: '16.x' - java-version: '11' + node-version: '18.x' + java-version: '17' vtag: ${{ env.vtag }} release: diff --git a/android/.gitignore b/android/.gitignore index 56cacb3ced2..b6bd8f6c33d 100644 --- a/android/.gitignore +++ b/android/.gitignore @@ -14,3 +14,4 @@ build/ /kroll-apt/bin/ /local.properties /titanium/assets/Resources/ti.internal/build.properties +/.idea/ diff --git a/android/.idea/codeStyles/Project.xml b/android/.idea/codeStyles/Project.xml index 8d13c04b12c..36d210ea229 100644 --- a/android/.idea/codeStyles/Project.xml +++ b/android/.idea/codeStyles/Project.xml @@ -9,6 +9,9 @@ + +