Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MF-171: Fix return types #64

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

MF-171: Fix return types #64

wants to merge 1 commit into from

Conversation

stoyicker
Copy link
Member

This makes the IDE complain, which is annoying when looking at actual problems.

@stoyicker stoyicker requested a review from a team as a code owner July 2, 2024 11:38
@stoyicker stoyicker enabled auto-merge July 2, 2024 11:38
@stoyicker stoyicker changed the base branch from main to jantonio/mediaproductransition_changes July 4, 2024 11:13
auto-merge was automatically disabled July 4, 2024 11:17

Head branch was modified

@stoyicker stoyicker marked this pull request as draft July 4, 2024 11:30
@stoyicker stoyicker marked this pull request as ready for review July 4, 2024 11:45
Base automatically changed from jantonio/mediaproductransition_changes to main August 5, 2024 08:02
@stoyicker stoyicker changed the title Fix return types MF-171: Fix return types Aug 30, 2024
@stoyicker stoyicker requested a review from a team September 4, 2024 11:05
michpohl
michpohl reviewed Sep 9, 2024
View reviewed changes
Copy link
Contributor

@michpohl michpohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are two other commits in this PR that don't seem to be related? Just wondering if that is by mistake or if I'm missing something?

@stoyicker
Copy link
Member Author

yeah wrong base looks like, I'll take a look

@stoyicker
MF-171: Fix return types
21de5b3 
This makes the IDE complain, which is annoying when looking at actual problems.
@stoyicker
Copy link
Member Author

sorted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michpohl michpohl michpohl left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stoyicker @michpohl