Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional global JSONs #1

Open
muriloricci opened this issue Nov 8, 2022 · 2 comments
Open

Additional global JSONs #1

muriloricci opened this issue Nov 8, 2022 · 2 comments

Comments

@muriloricci
Copy link
Contributor

Would it be possible to add more global JSONs? I have some ideas, maybe you could add some if you think it's interesting or useful:

  • Bosses that are not included in the Bosstiary
  • Rare creatures (i.e. midnight panther, yeti, undead cavebear, dire penguins) [could perhaps be added with bosses not included in the Bosstiary]
  • Rookgaard exclusive bosses
  • Only creatures?
  • Creatures that are not included in the bestiary
@mathiasbynens
Copy link
Member

I'm definitely open to this. In addition to your suggestions, I had a TODO list here:

// TODO: Blood Brothers bosses
// TODO: Pharaohs
// TODO: Secret library bosses
// TODO: Grave Danger bosses
// TODO: Cults bosses
// TODO: Vengoth mini + final bosses
// TODO: Port Hope flimsy bosses
// TODO: Falcon Bastion mini bosses + Oberon
// TODO: Cobra Bastion mini bosses + Scarlett
// TODO: Mini asura bosses
// TODO: True asura bosses

Here's an example patch that adds some new boss categories, which then in turn result in additional files being created: 25fabc3

We could do the same thing for non-bosses. Most of the work is compiling the list of creatures per category -- so if anyone wants to help but doesn't feel like sending a patch, just commenting here with the creature lists would be super helpful!

mathiasbynens added a commit that referenced this issue Nov 15, 2022
This makes it easy to add additional creature categories in the future.

Issue: #1
mathiasbynens added a commit that referenced this issue Nov 17, 2022
Using pretty boss/creature names makes it much easier to maintain the category lists.

There is now a separate conversion step that normalizes the pretty names to the less pretty names used in the kill statistics.

Issue: #1
@mathiasbynens
Copy link
Member

Added some more boss categories in 957164f.

mathiasbynens pushed a commit that referenced this issue Dec 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants