UpdateInfoFileName() returns random bytes from stack (Bugzilla Bug 2239)

[tianocore-issues]

This issue was created automatically with bugzilla2github

Bugzilla Bug 2239

Date: 2019-10-03T04:24:09+00:00
From: Heinrich Schuchardt <<xypron.glpk>>
To: Edhay <<edhaya.chandran>>
CC: edhaya.chandran, eric.jin, @cetola, supreeth.venkatesh, xypron.glpk

Last updated: 2021-11-11T09:47:04+00:00

[tianocore-issues]

Comment 9916

Date: 2019-10-03 04:24:09 +0000
From: Heinrich Schuchardt <<xypron.glpk>>

• Industry Specification: ---
• Release Observed: EDK II Master
• Releases to Fix: EDK II Master
• Target OS: ---
• Bugzilla Assignee(s): Edhay <<edhaya.chandran>>

In some cases (Size <= FileInfo->Size) UpdateInfoFileName() does not initialize the variable status. So random bytes from the stack will be returned.

I guess that status should be initalized to EFI_SUCCESS.

The problem was indicated by CppCheck (http://cppcheck.sourceforge.net/).

Please, run cppcheck on the whole of edk2-test to discover a lot of similar problems.

[tianocore-issues]

Comment 10148

Date: 2019-10-21 12:52:26 +0000
From: supreeth.venkatesh

In pipeline for next release.

[tianocore-issues]

Comment 17147

Date: 2021-09-02 10:49:14 +0000
From: Edhay <<edhaya.chandran>>

Vincent to run cppcheck/Coverity and prepare the list of issue

[tianocore-issues]

Comment 17175

Date: 2021-09-06 09:04:32 +0000
From: Vincent Stehlé <<vincent.stehle>>

Created attachment 822
Cppcheck results

Cppcheck 2.3
edk2-test 6756aa2

Attachment: BZ-822-cppcheck.log

[tianocore-issues]

Comment 17452

Date: 2021-10-07 10:21:22 +0000
From: Edhay <<edhaya.chandran>>

Carolyn and Edhay to Volunteer to fix the CPPCheck Issues found.