Help with edk2 CI failure (renaming GCC5 to GCC): "Not found stuart_pr_eval: null"

[ghost]

In tianocore/edk2#4396 I'm attempting to rename all GCC5 references to GCC, since the GCC5 toolchain is now deprecated. However I'm running into the stuart_pr_eval failure which I can't replicate locally.

I was wondering if someone could take a look and let me know what I'm doing wrong?

##[debug]filename=stuart_pr_eval
##[debug]check path : null
##[error]Failed which: Not found stuart_pr_eval: null
##[debug]Processed: ##vso[task.issue type=error;]Failed which: Not found stuart_pr_eval: null
(node:192) Warning: Use Cipheriv for counter mode of aes-256-ctr
...
(node:192) Warning: Use Cipheriv for counter mode of aes-256-ctr
##[debug]task result: Failed
##[error]undefined failed with error: Failed which: Not found stuart_pr_eval: null
##[debug]Processed: ##vso[task.issue type=error;]undefined failed with error: Failed which: Not found stuart_pr_eval: null
##[debug]Processed: ##vso[task.complete result=Failed;]undefined failed with error: Failed which: Not found stuart_pr_eval: null
##[debug]Handler exit code: 0
Finishing: Check if EmulatorPkg need testing

[makubacki]

I believe some GCC5 references in pipeline files still needed to be updated. I made that change on top of your branch in a commit in this PR (feel free to cherry-pick it): tianocore/edk2#4400

The build looks better from a pr_eval perspective. There appears to be a legit issue in ArmVirtPkg now:

INFO - Active Platform          = /__w/1/s/ArmVirtPkg/ArmVirtQemu.dsc
INFO - ..... done!
INFO - Building ... /__w/1/s/MdePkg/Library/BaseStackCheckLib/BaseStackCheckLib.inf [AARCH64]
INFO - Building ... /__w/1/s/ArmPkg/Library/CompilerIntrinsicsLib/CompilerIntrinsicsLib.inf [AARCH64]
INFO - "gcc" -MMD -MF /__w/1/s/Build/ArmVirtQemu-AARCH64/DEBUG_GCC/AARCH64/MdePkg/Library/BaseStackCheckLib/BaseStackCheckLib/OUTPUT/BaseStackCheckGcc.obj.deps  -g -Os -fshort-wchar -fno-builtin -fno-strict-aliasing -Wall -Werror -Wno-array-bounds -include AutoGen.h -fno-common -ffunction-sections -fdata-sections -DSTRING_ARRAY_NAME=BaseStackCheckLibStrings -g -Os -fshort-wchar -fno-builtin -fno-strict-aliasing -Wall -Werror -Wno-array-bounds -include AutoGen.h -fno-common -mlittle-endian -fno-short-enums -fverbose-asm -funsigned-char -ffunction-sections -fdata-sections -Wno-address -fno-asynchronous-unwind-tables -fno-unwind-tables -fno-pic -fno-pie -ffixed-x18 -mcmodel=small -flto -Wno-unused-but-set-variable -Wno-unused-const-variable -DDISABLE_NEW_DEPRECATED_INTERFACES  -c -o /__w/1/s/Build/ArmVirtQemu-AARCH64/DEBUG_GCC/AARCH64/MdePkg/Library/BaseStackCheckLib/BaseStackCheckLib/OUTPUT/./BaseStackCheckGcc.obj -I/__w/1/s/MdePkg/Library/BaseStackCheckLib -I/__w/1/s/Build/ArmVirtQemu-AARCH64/DEBUG_GCC/AARCH64/MdePkg/Library/BaseStackCheckLib/BaseStackCheckLib/DEBUG -I/__w/1/s/MdePkg -I/__w/1/s/MdePkg/Include -I/__w/1/s/MdePkg/Test/UnitTest/Include -I/__w/1/s/MdePkg/Test/Mock/Include -I/__w/1/s/MdePkg/Library/MipiSysTLib/mipisyst/library/include -I/__w/1/s/MdePkg/Include/AArch64 /__w/1/s/MdePkg/Library/BaseStackCheckLib/BaseStackCheckGcc.c
INFO - Trim --asm-file -o /__w/1/s/Build/ArmVirtQemu-AARCH64/DEBUG_GCC/AARCH64/ArmPkg/Library/CompilerIntrinsicsLib/CompilerIntrinsicsLib/OUTPUT/AArch64/Atomics.i -i /__w/1/s/Build/ArmVirtQemu-AARCH64/DEBUG_GCC/AARCH64/ArmPkg/Library/CompilerIntrinsicsLib/CompilerIntrinsicsLib/OUTPUT/inc.lst /__w/1/s/ArmPkg/Library/CompilerIntrinsicsLib/AArch64/Atomics.S
INFO - gcc: error: unrecognized command-line option ‘-mlittle-endian’
INFO - make: *** [GNUmakefile:292: /__w/1/s/Build/ArmVirtQemu-AARCH64/DEBUG_GCC/AARCH64/MdePkg/Library/BaseStackCheckLib/BaseStackCheckLib/OUTPUT/BaseStackCheckGcc.obj] Error 1
INFO - 
INFO - 
INFO - build.py...
INFO -  : error 7000: Failed to execute command
INFO - 	make tbuild [/__w/1/s/Build/ArmVirtQemu-AARCH64/DEBUG_GCC/AARCH64/MdePkg/Library/BaseStackCheckLib/BaseStackCheckLib]
INFO - 
INFO - 
INFO - build.py...
INFO -  : error 7000: Failed to execute command
INFO - 	make tbuild [/__w/1/s/Build/ArmVirtQemu-AARCH64/DEBUG_GCC/AARCH64/MdePkg/Library/BaseReportStatusCodeLibNull/BaseReportStatusCodeLibNull]
INFO - 
INFO - 
INFO - build.py...
INFO -  : error 7000: Failed to execute command
INFO - 	make tbuild [/__w/1/s/Build/ArmVirtQemu-AARCH64/DEBUG_GCC/AARCH64/ArmPkg/Library/CompilerIntrinsicsLib/CompilerIntrinsicsLib]
INFO - 
INFO - 
INFO - build.py...
INFO -  : error F002: Failed to build module
INFO - 	/__w/1/s/MdePkg/Library/BaseStackCheckLib/BaseStackCheckLib.inf [AARCH64, GCC, DEBUG]
INFO - 
INFO - - Failed -
INFO - Build end time: 16:58:24, May.16 2023
INFO - Build total time: 00:00:06

[ghost]

That failure looks like something isn't setting GCC_AARCH64_PREFIX - it's probably setting GCC5_AARCH64_PREFIX instead.

[ghost]

Thanks! I think the remaining issue is because of the Ubuntu-GCC5.yml files. I think renaming them to Ubuntu-GCC.yml will fix it.

[ghost]

For future reference/notes, I missed the remaining references because ripgrep defaults to ignoring hidden/dot files and directories.
I had to run rg -g '!BaseTools' -. "GCC5"