updating to latest version fails to compile and error as dependency missing #171

sheikalthaf · 2020-09-21T09:28:15Z

Describe the bug
after upating to latest version I'm getting this error

ERROR in The target entry-point "material-community-components/color-picker" has missing dependencies:
 - @thebespokepixel/es-tinycolor
 - tinycolor2

To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

OS: [e.g. iOS]
Browser [e.g. chrome, safari]
Version [e.g. 22]

Additional context
Add any other context about the problem here.

aceleghin · 2020-09-21T10:05:43Z

Same error here, old import seems not exists anymore (in the doc I still see the v7 with this import:
import {MccColorPickerModule} from 'material-community-components' )
With the new import I have the same missing dependencies
Already tried to delete node modules but nothing changed.
I have angular 10.1.2

motabass · 2020-09-21T15:08:46Z

Hi. There is in fact a new peer dependency not packaged with the lib @thebespokepixel/es-tinycolor used for all the color calculations in the color-picker. This is missing in the docs and README.md and also the docs and demo are still on 7.0.0. The breaking change about secondary imports also should have been statet in the changelog. Sorry for that.

@tiaguinho can you update the demo? I already took care of the missing docs about new import method and peer dependency: #173

jordandh · 2020-09-21T22:21:13Z

Same error here, old import seems not exists anymore (in the doc I still see the v7 with this import:
import {MccColorPickerModule} from 'material-community-components' )
With the new import I have the same missing dependencies
Already tried to delete node modules but nothing changed.
I have angular 10.1.2

It looks like you import from subfolders now:
import { MccColorPickerModule } from 'material-community-components/color-picker';

motabass · 2020-09-22T14:12:47Z

Thats correct

eholman · 2020-09-29T11:46:15Z

@tiaguinho There is a good need for updated demo's/documentation.

Another error:

ERROR in src/app/shared/components/input/input.component.html:20:23 - error TS2322: Type '""' is not assignable to type '"openOnFocus" | "default"'.

20       <input matInput mccColorPickerOrigin #trigger="mccColorPickerOrigin" [formControlName]="controlName"  />

which should become either
<input matInput mccColorPickerOrigin="openOnFocus" #trigger="mccColorPickerOrigin" [formControlName]="controlName" /> or <input matInput mccColorPickerOrigin="default" #trigger="mccColorPickerOrigin" [formControlName]="controlName" />

I like the feature openOnFocus though 👍

motabass · 2020-09-30T15:22:38Z

@eholman the error appears only when having "strictTemplates" = true in your angularCompilerOptions.

I'll try to change the types to work with strict template type checks.

EDIT: i maybe found a solution already:
https://angular.io/guide/template-typecheck#troubleshooting-template-errors
https://angular.io/guide/template-typecheck#input-setter-coercion

motabass · 2020-09-30T16:30:26Z

5a1a341 should fix all error showing up due to strictTemplates checks

motabass · 2020-10-06T12:28:38Z

All changes are now documented and https://github.com/tiaguinho/material-community-components/releases/tag/v9.0.1 is released so this can be closed i think

motabass · 2020-10-07T22:23:50Z

The demo is now up to date:
https://tiaguinho.github.io/material-community-components/

eholman · 2020-10-09T11:14:02Z

5a1a341 should fix all error showing up due to strictTemplates checks

Good move and great job!

aceleghin · 2020-10-14T16:25:05Z

I still see tinycolor2 missing dependencies

motabass · 2020-10-15T10:33:34Z

@lippomano @sheikalthaf It seems as if an import from @types/tinycolor2 in the lib is causing this. Could you try if the error disapears if you add that to your devDependencies. I also changed the import to an type-only import import type { Instance } from 'tinycolor' in #181. I hope it helps.

tiaguinho · 2020-10-16T12:50:29Z

Thanks @motabass
@lippomano can you check with v9.0.2?

motabass · 2020-10-19T07:40:53Z

@tiaguinho 9.0.2 has _theming.scss missing!!

tiaguinho · 2020-10-19T09:50:00Z

@motabass I just publish a new version fixing this.
Thanks

@lippomano can you check version v9.0.3?

VladMstv · 2020-10-20T07:52:45Z

@tiaguinho Installed v 9.0.3 and installed additionally @thebespokepixel/es-tinycolor v 2.1.1
Keeps giving me this:

ERROR in node_modules/material-community-components/color-picker/color-picker.types.d.ts:2:13 - error TS1005: '=' expected.

2 import type { Instance } from 'tinycolor2';
              ~
node_modules/material-community-components/color-picker/color-picker.types.d.ts:2:31 - error TS1005: ';' expected.

2 import type { Instance } from 'tinycolor2';

motabass · 2020-10-20T12:12:32Z

@VladMstv which TypeScript version are you using? Seems to have no support for Type-only imports.

https://www.typescriptlang.org/docs/handbook/release-notes/typescript-3-8.html

VladMstv · 2020-10-20T12:16:40Z

@VladMstv which TypeScript version are you using? Seems to have no support for Type-only imports.

https://www.typescriptlang.org/docs/handbook/release-notes/typescript-3-8.html

@motabass
Yeah, seems like that, 3.7.5. I'll try to upgrade it.

devlfm · 2020-10-29T23:13:31Z

Hi, I'm also having this problem.. 9.0.3 didn't fix it.
I need the fix for the drag outside box on color picker, if there's another release with that fix I'm ok with that.

Angular CLI: 9.1.12
Node: 12.19.0
OS: linux x64

Angular: 9.1.12
... animations, cli, common, compiler, compiler-cli, core, forms
... language-service, localize, platform-browser
... platform-browser-dynamic, router
Ivy Workspace: Yes

Package                           Version
-----------------------------------------------------------
@angular-devkit/architect         0.901.12
@angular-devkit/build-angular     0.901.12
@angular-devkit/build-optimizer   0.901.12
@angular-devkit/build-webpack     0.901.12
@angular-devkit/core              9.1.12
@angular-devkit/schematics        9.1.12
@angular/cdk                      9.2.4
@angular/flex-layout              9.0.0-beta.31
@angular/material                 9.2.4
@ngtools/webpack                  9.1.12
@schematics/angular               9.1.12
@schematics/update                0.901.12
rxjs                              6.6.3
typescript                        3.8.3
webpack                           4.42.0

motabass · 2020-11-01T21:27:46Z

Being on typescript > 3.8 and adding @types/tinycolor2 to your devDependencies should fix it for now.

belivo · 2020-11-16T22:30:19Z

On a clean install I get this compilation error:

ERROR in node_modules/material-community-components/color-picker/color-picker.types.d.ts:41:29 - error TS2709: Cannot use namespace 'Instance' as a type.

41 export declare type Color = Instance;

tiaguinho · 2020-11-18T09:06:57Z

@belivo which Angular and MCC version are you using?

belivo · 2020-11-19T17:44:59Z

@tiaguinho
"@angular/cli": "10.1.7"
"typescript": "4.0.3"
I think it was version 9.0.3

muehan · 2021-08-11T19:46:30Z

no solution jet?

An error occurred during the build:
Error: The target entry-point "material-community-components/color-picker" has missing dependencies:
 - @thebespokepixel/es-tinycolor

    at TargetedEntryPointFinder.findEntryPoints (...\node_modules\@angular\compiler-cli\ngcc\src\entry_point_finder\targeted_entry_point_finder.js:40:23)

dependency:

Angular 12.2
material-community-components 11.0.0

dev-dependency:

@types/tinycolor2 1.4.3

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

updating to latest version fails to compile and error as dependency missing #171

updating to latest version fails to compile and error as dependency missing #171

sheikalthaf commented Sep 21, 2020

aceleghin commented Sep 21, 2020

motabass commented Sep 21, 2020 •

edited

Loading

jordandh commented Sep 21, 2020

motabass commented Sep 22, 2020

eholman commented Sep 29, 2020

motabass commented Sep 30, 2020 •

edited

Loading

motabass commented Sep 30, 2020

motabass commented Oct 6, 2020

motabass commented Oct 7, 2020

eholman commented Oct 9, 2020

aceleghin commented Oct 14, 2020

motabass commented Oct 15, 2020 •

edited

Loading

tiaguinho commented Oct 16, 2020

motabass commented Oct 19, 2020

tiaguinho commented Oct 19, 2020 •

edited

Loading

VladMstv commented Oct 20, 2020 •

edited

Loading

motabass commented Oct 20, 2020 •

edited

Loading

VladMstv commented Oct 20, 2020 •

edited

Loading

devlfm commented Oct 29, 2020

motabass commented Nov 1, 2020 •

edited

Loading

belivo commented Nov 16, 2020

tiaguinho commented Nov 18, 2020

belivo commented Nov 19, 2020 •

edited

Loading

muehan commented Aug 11, 2021

updating to latest version fails to compile and error as dependency missing #171

updating to latest version fails to compile and error as dependency missing #171

Comments

sheikalthaf commented Sep 21, 2020

aceleghin commented Sep 21, 2020

motabass commented Sep 21, 2020 • edited Loading

jordandh commented Sep 21, 2020

motabass commented Sep 22, 2020

eholman commented Sep 29, 2020

motabass commented Sep 30, 2020 • edited Loading

motabass commented Sep 30, 2020

motabass commented Oct 6, 2020

motabass commented Oct 7, 2020

eholman commented Oct 9, 2020

aceleghin commented Oct 14, 2020

motabass commented Oct 15, 2020 • edited Loading

tiaguinho commented Oct 16, 2020

motabass commented Oct 19, 2020

tiaguinho commented Oct 19, 2020 • edited Loading

VladMstv commented Oct 20, 2020 • edited Loading

motabass commented Oct 20, 2020 • edited Loading

VladMstv commented Oct 20, 2020 • edited Loading

devlfm commented Oct 29, 2020

motabass commented Nov 1, 2020 • edited Loading

belivo commented Nov 16, 2020

tiaguinho commented Nov 18, 2020

belivo commented Nov 19, 2020 • edited Loading

muehan commented Aug 11, 2021

motabass commented Sep 21, 2020 •

edited

Loading

motabass commented Sep 30, 2020 •

edited

Loading

motabass commented Oct 15, 2020 •

edited

Loading

tiaguinho commented Oct 19, 2020 •

edited

Loading

VladMstv commented Oct 20, 2020 •

edited

Loading

motabass commented Oct 20, 2020 •

edited

Loading

VladMstv commented Oct 20, 2020 •

edited

Loading

motabass commented Nov 1, 2020 •

edited

Loading

belivo commented Nov 19, 2020 •

edited

Loading