Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to Kotlin #74

Open
shbhmnk opened this issue Oct 2, 2019 · 8 comments · May be fixed by #75
Open

Migrate to Kotlin #74

shbhmnk opened this issue Oct 2, 2019 · 8 comments · May be fixed by #75

Comments

@shbhmnk
Copy link

shbhmnk commented Oct 2, 2019

Convert the code base to Kotlin to leverage features provided by the language.
@thyrlian
Copy link
Owner

thyrlian commented Oct 2, 2019

Yep, will try to migrate when I got time.

@shbhmnk
Copy link
Author

shbhmnk commented Oct 2, 2019

Need a hand? Will shoot some PR your way if that's okay.

@thyrlian
Copy link
Owner

thyrlian commented Oct 3, 2019

Sure, please go ahead. Thanks for your contribution.

@shbhmnk shbhmnk linked a pull request Oct 5, 2019 that will close this issue
Open
@shbhmnk
Copy link
Author

shbhmnk commented Oct 5, 2019

Hi @thyrlian, I have started working on migrating the project to Kotlin. Here, #75 as the initial PR, I have started with few test classes.

Please let me know if you would like any changes in this. I will follow up with rest of the test cases and if all is well then I will start migrating the library as well.

@thyrlian
Copy link
Owner

thyrlian commented Oct 6, 2019

Thanks @shubh10 for your PR, will check once I'm free.

@shbhmnk
Copy link
Author

shbhmnk commented Oct 6, 2019

@thyrlian sure. Take your time. I'll work on rest of the codebase once we are okay with this.

@temirnurdin
Copy link
Contributor

@thyrlian Here is new PR: #84

@shbhmnk
Copy link
Author

shbhmnk commented Jan 10, 2021

Hey @temirnurdin could you please review #75 whenever you get a chance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Kotlin Migration: Convert tests to Kotlin part 1 shbhmnk/AwesomeValidation
3 participants
@thyrlian @shbhmnk @temirnurdin