Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

calendar readonly cannot be unset by user #46

Open
opto opened this issue Sep 30, 2024 · 2 comments
Open

calendar readonly cannot be unset by user #46

opto opened this issue Sep 30, 2024 · 2 comments
Labels
api: calendar This issue is about the calendar API experimeent bug Something isn't working good first issue Good for newcomers

Comments

@opto
Copy link

opto commented Sep 30, 2024

84f9081, still relevant?

experiment creates an readonly calendar, and the UI cannot unset readonly in calendar properties (is greyed out)

@opto
Copy link
Author

opto commented Sep 30, 2024

this seems to be relted to the calendar being immutable, when I look at the code, so this issue may be obsolete

@kewisch
Copy link
Member

kewisch commented Oct 1, 2024

It seems to me the default if not specified should be that calendars are mutable. There are two options:

  1. Rename the property from mutable to immutable. If immutable is not specified or explicitly false, everything is normal
  2. Fix the check from !mutable to mutable === false so that only explicitly false makes the calendar immutable.

@kewisch kewisch added good first issue Good for newcomers bug Something isn't working api: calendar This issue is about the calendar API experimeent labels Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: calendar This issue is about the calendar API experimeent bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants