Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IET NG Thunderbird 78 Update - Release/Tasks #143

Closed
41 tasks done
cleidigh opened this issue Aug 30, 2020 · 55 comments
Closed
41 tasks done

IET NG Thunderbird 78 Update - Release/Tasks #143

cleidigh opened this issue Aug 30, 2020 · 55 comments
Assignees

Comments

@cleidigh
Copy link
Collaborator

cleidigh commented Aug 30, 2020

It's under review!
https://github.com/thundernest/import-export-tools-ng/blob/v10.0.0/xpi/import-export-tools-ng-10.0.0-tb.xpi

Track Conversion/Beta Here:

Current Beta:
https://github.com/thundernest/import-export-tools-ng/blob/v10.0.0/xpi/import-export-tools-ng-10.0.0-b15-tb.xpi

Status:

  • fix EML import, hotkeys
  • runs in both 68 and 78
  • Backup fixes
  • fixed profile import
  • fixed backup spiritual
  • basic testing
  • all locales fixed
  • fixed mboxdialog ( reference,cancel)
  • fixed menus
  • various bug fixes

Current Work:

Initial Tasks:

  • - Branch, tracking issue - 5m
  • - Update build scripts - 2m
  • - Reread WindowListenerAPI, download - 10m
  • - Fix versions - 1m

Main Conversion Tasks:

Cleanup/Release Tasks:

  • start top to bottom testing
  • update change log
  • post to review
@cleidigh cleidigh self-assigned this Aug 30, 2020
@cleidigh cleidigh added this to the v10.0.0 milestone Aug 30, 2020
@cleidigh cleidigh pinned this issue Aug 30, 2020
@kunalbedi
Copy link

Cannot wait for you to update the release.

Thank you for the prompt action on this one.
Most appreciated.

Regards
Kunal Bedi

@cleidigh
Copy link
Collaborator Author

cleidigh commented Sep 2, 2020

@kunalbedi
first pass just posted

@kunalbedi
Copy link

kunalbedi commented Sep 2, 2020

@cleidigh Thank you for the quick turnaround. I am so humbled and impressed.
I installed the beta file and it is working as my needs are. I have not thoroughly tested but it did export my messages as EML format as I wanted and as it used to.

My thunderbird: 78.2.1 (32-bit)

I can confirm that the menu on right-click on folders appears for the plugin and that the option "Export all messages in folder > EML format" works as it should.

Thank you very much Christopher.

Regards
Kunal Bedi

@rphair
Copy link

rphair commented Sep 2, 2020

@cleidigh thanks also from here... I realise what a hindrance it is to my workflow to be without this extension and am very grateful for your work.

FYI (on Ubuntu 18.04 / Tbird 78.2.1) we weren't told a restart was required after installing the extension, but we didn't see any of the extension's menu selections or folder & email context menus until after restarting Thunderbird.

@cleidigh
Copy link
Collaborator Author

cleidigh commented Sep 2, 2020

@rphair
Thanks. any output in the Debug log ?
I will see what 68 on my VM does
I do not have 78 I will probably create a separate VM
Christopher

@rphair
Copy link

rphair commented Sep 2, 2020

I'll have a look if you tell me where or what pathname to check... as far as I can tell it's working normally except that an advisement to restart Tbird might be appropriate if it still behaves that way upon official release. :)

@cleidigh
Copy link
Collaborator Author

cleidigh commented Sep 2, 2020

now I am a bit confused.
I understood from your post above that you did not see any of the menus installed even after restarting.
now as I understand it once you did restart you get the menus and the functionality that you try works, yes?
I also just confirmed it works on Mint 18 with Thunderbird 68
I will have to check if there is any reason you had to restart. maybe first install?
Christopher

update
my apologies I missed the "until restarting"

it works after that

@ferthalangur
Copy link

Greetings,

I just attempted to install import-export-tools-ng-10.0.0.b4-tb.xpi into Thunderbird 78.2.1 and the message I receive is

mozapps The add-on downloaded from this site could not be installed because it appears to be corrupt.

I am running on MacOS 10.15.6

Any ideas what I'm doing wrong?

rob

@cleidigh
Copy link
Collaborator Author

cleidigh commented Sep 4, 2020

@ferthalangur
I was able to do a couple of tests. I have two systems El Capitan and Mojave
I have to do everything remotely by voice being disabled so I am rather limited
on anything other than Windows.
the extension works on El Capitan , 'but I can confirm it does not install on Mojave
I do not even get anything meaningful error wise
I also tried another extension with the same results
I am thinking that the OS X Thunderbird 78 has some issues
I will try and investigate, however I don't want to delay if it's out of my control
Christopher

@ferthalangur
Copy link

@cleidigh ... I am going to try something. The contents of the file that I downloaded does not look like any kind of extension ... it looks like the html from a Github page, saved in a file named import-export-tools-ng-10.0.0.b4-tb.xpi .

@cleidigh
Copy link
Collaborator Author

cleidigh commented Sep 4, 2020

@ferthalangur
sounds good
the xpi file is just a zip format if you unzip it you will see various JavaScript and other files
Christopher

@ferthalangur
Copy link

OK ... this looks like user error. I should have clicked on the link, and then from the page that it links to, click on the Download button. Instead, I used Save Link As on that link ... which works fine if the URL is for a binary file ... but downloaded the HTML file of the "blob" page in this case ... into a file named import-export-tools-ng-10.0.0.b4-tb.xpi .

Once I successfully downloaded the .xpi file, Thunderbird loaded it without complaint into 78.2.1 (64 bit) in MacOS Catalina.

@cleidigh
Copy link
Collaborator Author

cleidigh commented Sep 4, 2020

great
do you get the menus, trying anything yet?
I could not load it

@ferthalangur
Copy link

ferthalangur commented Sep 5, 2020

It loaded up fine.

  • All four export folder functions work as expected on a single (complex multi-layered) folder of folders of old
  • I selected several folders and ran "Export all messages in the folder" in EML format, and it did what was expected. {{ What I did not expect, although I have not read the documentation or used it before, so this may be expected behavior, is that each folder name was suffixed with a date and time stamp. }}

@ferthalangur
Copy link

Found a problem ... I selected a folder, then mouse right on ImportExportToolsNG -> Search and Export ...

A small, scrunched-up message / error box appears with the following message when expanded:

Problem_loading_page_and_gmail_inbox_-_Local_Folders

Something did not get bundled into the .xpi file?

@cleidigh
Copy link
Collaborator Author

cleidigh commented Sep 5, 2020

@ferthalangur
thanks for the catch!
yes, I missed converting the extension on this dialog
it will be fixed in b5 as well as a big issue with multiple selected PDF messages
Christopher

@DrStrange
Copy link

DrStrange commented Sep 5, 2020

Import Profile not working yet?-
Buttons at the bottom not labelled. Clicking options on each page -path of the profile to import, start import, run the Profile Manager - nothing happens, profile is not imported.
Export Profile appears to work, I created another profile using profile manager, copied files from IET ToolsNG exported profile folder into this new profile folder, selected the new profile, no problems.
Thanks for getting this working with Thunderbird 78. I use Windows 8.1

@cleidigh
Copy link
Collaborator Author

cleidigh commented Sep 5, 2020

@DrStrange
Thanks !
good chance there are some issues, still wrestling but other stuff, about to post b5
might be able to check this out before, but I don't want to wait too long since
b5 deals with several other issues
Christopher

@cleidigh
Copy link
Collaborator Author

cleidigh commented Sep 6, 2020

@DrStrange
b5 does not fix it, more complicated unfortunately

@cleidigh
Copy link
Collaborator Author

cleidigh commented Sep 8, 2020

@DrStrange
Try b6 import wizard fixed as well as export

@monorailsmoothie
Copy link

Hello @cleidigh and thanks a lot for all the efforts you've put to this add-on.

I've got a .mbox file that represents an account at the hey.com service, and I tried to import it using the b6 build and got the following error:

Uncaught TypeError: tempfolder.Delete is not a function  mboximport.js:431:13
    trytocopy chrome://mboximport/content/mboximport/mboximport.js:431
    importmbox chrome://mboximport/content/mboximport/mboximport.js:628

Not a single message appears, only an empty folder named after the input file appears once I've restarted Thunderbird.

I'm running version 78.2.1 on my macOS Catalina 10.15.6.

Do you have any idea what could be wrong?

@DrStrange
Copy link

DrStrange commented Sep 8, 2020

@cleidigh,
Thanks for b6, can now import profile.
I notice however one issue with b6 - when you run the Profile Manager at the end of the import wizard, and the Profile Manager opens, I get a very tiny window appearing, entitled "problem loading page". It is so tiny all it has is a close button and a line underneath the title. This window also appears everytime I close TB 78.2.1 in Windows 8.1 I think I remember this window appearing when closing TB with b4 and b5 also. If I disable or remove IET NG, this window never appears.
So don't know if this window appearing is a bug in import profile wizard or some other part of IET NG, as it appears in Import Profile Wizard and also when closing TB.
Capture

@cleidigh
Copy link
Collaborator Author

cleidigh commented Sep 8, 2020

@TeroDev
where did the m box file come from ? some have different formats that are not compatible
if you could post a portion of the file that would help
question

@kunalbedi
Copy link

@cleidigh
Updated to b8.
Status messages are back. Yipee!!!

BUT https://www.screencast.com/t/kPMKfPAY

this message above stays on the status bar after successful export.
The Stop button also works if clicked . This should not be the case.

Please do check when you have time for this minor niggle.

I am on Thunderbird 78.2.1 (32-bit) on Win 10

Regards
Kunal Bedi

@DrStrange
Copy link

@cleidigh
The extra window bug no longer appears with b8.
Thanks!

@monorailsmoothie
Copy link

where did the m box file come from ? some have different formats that are not compatible

This particular file was created by hey.com when one chooses Export Data from the main menu. I also tried to import several .mbox files created by ProtonMail import-export tool, but got the very same error.

if you could post a portion of the file that would help

I'll have a further look of the file and see if I could provide a sample for you.

@cleidigh
Copy link
Collaborator Author

cleidigh commented Sep 9, 2020

@TeroDev
Also check out the ConsoleOutput ( Shift control J)
you can Copy and post here
what sequence of commands are you using?

@cleidigh
Copy link
Collaborator Author

cleidigh commented Sep 9, 2020

@kunalbedi
so far I cannot find which export operation makes the status text rename.
there is a preference,
extensions.importexporttoolsng.delay.clean_statusbar
that defaults to 5000 === 5s
if this somehow got set zero
the messages remain
@cleidigh

@cleidigh
Copy link
Collaborator Author

@kunalbedi
I found what I missed
check out b9

@kunalbedi
Copy link

@cleidigh I just installed b9 and I see that it is working I guess.
I will try some more and give a definitive answer soon.
Thanks, Christopher for such a fast turn around. You are an inspiration.

@cleidigh
Copy link
Collaborator Author

All
anymore Feedback?
I'm trying to decide to release
thanks
Christopher

@slrslr
Copy link

slrslr commented Sep 18, 2020

anymore Feedback?

Sorry for OT? so i have downloaded 10.0.0 b9 from https://github.com/thundernest/import-export-tools-ng/blob/v10.0.0/xpi/ and then drag & drop the file to the Thunderbird extensions section, enabled it and in the Import tool, Import exerything, it says No application to import data from. Mail only import shows Becky and outlook where it is unable to find mail.

@cleidigh
Copy link
Collaborator Author

@slrslr
first best to get the latest: b13 at the moment, I always have a link to the latest beta for the top of the thread.
you are looking at the internal import export, not the extension functionality. you used various contexts when used to access to import-export functions. There is also localized help built-in: one way you can get to the functionality as well as help: Tools/ ImportExportTools NG help us at the bottom of the menu and that describes almost menu functions.
Christopher

@slrslr
Copy link

slrslr commented Sep 19, 2020

@cleidigh
i am confused. You suggest i should use internal import tool and not the extension functionality, but that is what i believe i already tried - Main Thunderbird menu button / Tools / Import... and i see what i mention in my previous comment: "Import exerything, it says No application to import data from. Mail only import shows Becky and outlook where it is unable to find mail."
In Addons/Extensions/IET NG section i see IET NG active and do no see any importing possibility. b13 and Thunderbird 78.2.1 (64-bit)

@cleidigh
Copy link
Collaborator Author

@slrslr
Sorry for the confusion, lousy dictation..
What I meant was that the dialogue you were looking at that includes Becky is Thunderbird 's import capability not the extension.
the extensions install several Menus under Tools, the message context menu, the folder context menu and the search dialogue. below I show the tools menu with the help option highlighted
if you go to help which is totally localized list all of the functions.
there has always been little help, I have been trying to improve that
let me know if this helps
Christopher
image

@slrslr
Copy link

slrslr commented Sep 19, 2020

Thank you, indeed. I have not seen that top menu on the image. Possibly hidden by default :-S I had to right click the top bar and select the "Menu bar" to display. I expected there will be only one Tools menu :)
thunderbird-tools-menu

So i selected the import method using folders with eml files and it started. Several times complained about:

A script on this page may be busy, or it may have stopped responding. You can stop the script now, or you can continue to see if the script will complete.

Script: chrome://mboximport/content/mboximport/mboximport.js:1086

So i ticked the box to mute it in future.
Unfortunately i am having issue Thunderbird (had same with Firefox previously) where the Thunderbird shows in Windows 10 taskbar on the bottom, but clicking it does nothing, so i had to close TB after its CPU utilization ceased (after import complete) without seeing result.

After starting it again, it appears that the import worked, e-mail that i opened is readable. When i moved the imported e-mails from imported folder to Inbox, and tried the import again (to see if it will work, add only new e-mails), it looks like if it imported two times, once into Inbox and once into separate folder at the same level as Inbox named "Local folders" - name used in previous mail client. Maybe it happened because i was currently in the Inbox when i requested import.

@monorailsmoothie
Copy link

@cleidigh I can confirm that with the b14 I'm able to import .mbox files again - thank you :)

@andystyl
Copy link

andystyl commented Sep 25, 2020

Installed beta version b15 and worked like a charm.
Exported and imported on 2 different PCs both with Thunderbird v78.
Both using Windows 10 x64.
Thank you for saving me.

@cleidigh
Copy link
Collaborator Author

@andystyl
Great! thanks
I believe b16 Can hopefully be released by the end of this weekend
hopefully a few more people will try b15
Christopher

@kunalbedi
Copy link

kunalbedi commented Sep 26, 2020 via email

@cleidigh
Copy link
Collaborator Author

@kunalbedi
Thanks! would you mind just letting me know your OS and use cases just so I have a better understanding
of various things people tested
if all goes well I will post the release to the queue today.
@cleidigh

@kunalbedi
Copy link

kunalbedi commented Sep 28, 2020 via email

@kunalbedi
Copy link

Congrats @cleidigh ,

For putting the final version of the review.

Just one thing as I am not much aware of the process.

Will the beta I have automatically update to the final release or I have to jump through some hoops once it is in action?

Regards
Kunal Bedi

@cleidigh
Copy link
Collaborator Author

@kunalbedi
Thanks
to be honest I am not sure ,if it does automatically upgrade, try to check for updates button
otherwise uninstall and install from ATN
Christopher

@lucknaumann
Copy link

@cleidigh Thanks for this great add-on!
@kunalbedi I just tried it and it didn't auto-update. Went to the Thunderbird Add-on page (in Thunderbird, right after it updated to 78.3.1 (64-bit)) and installed from there. I'm on Windows 10.

@cleidigh
Copy link
Collaborator Author

@lucknaumann
@kunalbedi
Thanks
I just tried checking for updates (starting with beta installed) - does not recognize updating
installed "official" 4.1.0 then recognized there was an update
clearly when you are using an unreleased version you are out of the update loop
@cleidigh

@cleidigh
Copy link
Collaborator Author

All beta users:

if you have installed any beta you will have to install the official version manually.
Christopher

@kunalbedi
Copy link

@cleidigh
Thanks a lot!!!

You are a gem.

@Sytten
Copy link

Sytten commented Oct 10, 2020

Any plan to support Thunderbird 82? I can't seem to install it on the latest beta.

@cleidigh
Copy link
Collaborator Author

@Sytten
yes, just not sure when, several other 78 conversions I have to dear
Christopher

@cleidigh cleidigh unpinned this issue Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

10 participants