Adds tiff files when using images.fromtif default 'tif extension #357
Conversation
|
Cool @boazmohar ! I agree this would be good to support, another idea might be to just say if either |
| @@ -74,3 +74,24 @@ def test_local_recursive_nested(tmpdir): | |||
| make(tmpdir, filenames) | |||
| actual = LocalFileReader().list(str(tmpdir), recursive=True) | |||
| assert parse(actual) == expected | |||
|
|
|||
There was a problem hiding this comment.
These should probably be in test_images_io.py, the test_readers.py are for testing generic io functionality relevant to all data types
There was a problem hiding this comment.
I tried moving them but I would need to either import the make and parse functions or copy paste them into test_images_io.py. I think they belong in the test_readers.py that is the main function that I changed.
There was a problem hiding this comment.
Ah I see, that's fine then.
|
For testing on |
|
@freeman-lab Sure I can make it symmetric but what about a case where someone wants only tif or only tiff files. If you are OK without these options I am too. I thought to have a default of 'tifs' and that would be 'symmetric' as it will include tif and tiff. Specifying another extension will work as expected. |
|
@freeman-lab fish example is working. Thanks. |
|
Ah, totally see where you were coming from, I think my call would be to just make it symmetric, as both extensions really do fundamentally specify the same format (see e.g. http://superuser.com/questions/287776/differences-between-tiff-tif-tiff-tif), and it seems very unusual for people to have both in the same location. |
|
@freeman-lab Thanks for the feedback, ready to merge in my opinion. |
|
ok great @boazmohar , merging this in! |
Solves #341
@freeman-lab What is a good default behavior as this is implemented now, it will not enable you to select either tif or tiff from your folders.
I could change the default
ext='tif'to `'ext='tifs' to make it possible, What do you think?Also didn't test with s3, any thoughts as to how?