Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pyDNS dependency? #8

Open
robertlagrant opened this issue Jul 28, 2015 · 3 comments
Open

pyDNS dependency? #8

robertlagrant opened this issue Jul 28, 2015 · 3 comments

Comments

@robertlagrant
Copy link

I'm trying to install on Python 3 on Windows (the least-likely-to-work combination) and while passlib installed fine, it borked on pyDNS. I'm just wondering what that dependency is for, since the only time I see it when I search the repo is in the setup.py file.

Can it be safely removed?

@robertlagrant
Copy link
Author

Update: it installed fine from https://github.com/robertlagrant/pyramid_simpleauth, where I removed that dep. Will see what happens.

@thruflo
Copy link
Owner

thruflo commented Jul 28, 2015

Might be something to do with the email validator, which I think has a resolve dns option?

@matthewblain
Copy link

it looks like PyDNS offers a module named 'DNS', which is not referenced anywhere in the simpleauth source code. can this be fixed, since it's apparently not used?
email validation appears to be done using formencode which in turn appears to use dnspython (not PyDNS), but it also does not require it--it will fail the import, issue a warning, and keep going.

matthewblain added a commit to matthewblain/pyramid_simpleauth that referenced this issue Apr 15, 2016
I can find no references to DNS in the source code. Fixes
thruflo#8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants