Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugins: Struct tags #230

Open
abhinav opened this issue Sep 19, 2016 · 3 comments
Open

Plugins: Struct tags #230

abhinav opened this issue Sep 19, 2016 · 3 comments

Comments

@abhinav
Copy link
Contributor

abhinav commented Sep 19, 2016

We should allow customization of struct tags through plugins. The plugin would probably need access to some information about the field for which the tag is being generated. We could provide built-in plugins for JSON/YAML tags.

@motiejus
Copy link

motiejus commented Dec 6, 2016

cc @edast

We would appreciate this feature for our GraphQL endpoints, which could use thriftrw-based schemas.

I.e. in some GraphQL internal services we emit JSON. Currently, that JSON is not typed. We would like to specify the returned JSON with Thrift. However, the rules for JSON field names differ for GraphQL and JSON.

With this feature, our returned JSON could be specified in Thrift. If you make this happen or prioritize, please let us know.

@martynasb
Copy link

+1

@abhinav
Copy link
Contributor Author

abhinav commented Dec 14, 2016

@peter-edge plugins that have access to all the information from the Thrift
files is something we can eventually support. Please create a separate issue
for that. Note that depending on project priorities, we may not be able to get
to that soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants