Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

digest difference on zip file when migration from Getdown version 1.7 to version 1.8 #275

Open
serge-xav opened this issue Feb 29, 2024 · 3 comments

Comments

@serge-xav
Copy link

Hi,

When trying to upgrade my getdown version to v1.8 I have a strange behavior on zip file contained in my app (it's the only zip file that I have) :
The digest result differs on the zip file, and only on the zip file, if the digester is run with getdown version 1.7, or with version 1.8
The file is not changed.
Do you have any idea why this behavior ? I'm a bit stuck with this issue in my update getdown process.

@serge-xav
Copy link
Author

My issue is similar to the comment here :
#206 (comment)

@bekoenig
Copy link
Contributor

Hi @serge-xav,

as I mentioned in #276, the new algorithm is a good way to compute a stable zip digest. So a new zip package with a same content, but different file attributes has the same digest.

But you are right, that this change is incompatible from client side perspective. To be compatible, we have to compute the digest twice (old and new way).

@serge-xav
Copy link
Author

Hi @bekoenig , thanks for your reply,

I understand your point of view, and I know that keeping things compatible accross versions can be difficult. We don't know either if most Getdown users are still dealing with version 1.7 or have migrated to 1.8

On my side, I've a workaround for #275 which is to remove .zip file from the getdownized package, when I'll upgrade my application packages to Getdown 1.8

I guess we should keep this Issue Opened, and see if others have same issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants