Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests and coverage workflow fails #2405

Closed
rawdaGastan opened this issue Aug 22, 2024 · 8 comments
Closed

Tests and coverage workflow fails #2405

rawdaGastan opened this issue Aug 22, 2024 · 8 comments
Assignees
@rawdaGastan
Labels
type_bug Something isn't working
Milestone
3.12

Comments

@rawdaGastan
Copy link
Contributor

Describe the bug

  • Tests and coverage workflow fails

https://github.com/threefoldtech/zos/actions/runs/10505891426/job/29104380307?pr=2404
@rawdaGastan rawdaGastan added the type_bug Something isn't working label Aug 22, 2024
@rawdaGastan rawdaGastan added this to the 3.12 milestone Aug 22, 2024
@rawdaGastan rawdaGastan mentioned this issue Aug 22, 2024
Merged
4 tasks
@iwanbk
Copy link
Member

iwanbk commented Aug 22, 2024 •
edited
Loading

i've added the fix on my PR #2395

@rawdaGastan
Copy link
Contributor Author

Please mention the issue there, Thanks :)

@rawdaGastan rawdaGastan moved this to In Progress in 3.15.x Aug 22, 2024
@iwanbk iwanbk mentioned this issue Aug 22, 2024
Open
4 tasks
@iwanbk
Copy link
Member

iwanbk commented Aug 22, 2024

Please mention the issue there, Thanks :)

done

@xmonader
Copy link
Collaborator

i've added the fix on my PR #2395

Hey @iwanbk please create a separate PR for this one to be reviewed and merged separately

@iwanbk
Copy link
Member

iwanbk commented Aug 23, 2024

Hey @iwanbk please create a separate PR for this one to be reviewed and merged separately

The fix actually already committed last week because my PR also broken because of this issue

@ashraffouda
Copy link
Collaborator

@iwanbk we need this on a separate PR, can u plz do this?

@rawdaGastan rawdaGastan assigned rawdaGastan and unassigned iwanbk Sep 18, 2024
@rawdaGastan rawdaGastan mentioned this issue Sep 18, 2024
Merged
@rawdaGastan rawdaGastan moved this from In Progress to Pending Review in 3.15.x Sep 18, 2024
@iwanbk
Copy link
Member

iwanbk commented Sep 19, 2024

@iwanbk we need this on a separate PR, can u plz do this?

i saw @rawdaGastan already working on it on #2423.

@rawdaGastan rawdaGastan moved this from Pending Review to In Verification in 3.15.x Sep 22, 2024
@rawdaGastan rawdaGastan mentioned this issue Oct 2, 2024
Merged
@Omarabdul3ziz
Copy link
Contributor

all workflow passed

@github-project-automation github-project-automation bot moved this from In Verification to Done in 3.15.x Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rawdaGastan rawdaGastan

Labels
type_bug Something isn't working
Projects
3.15.x
Status: Done
Milestone
3.12
Development

No branches or pull requests
5 participants
@xmonader @iwanbk @ashraffouda @Omarabdul3ziz @rawdaGastan