Indent with javascript tag #73
Open
+22
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry I've neglected this for so long! I think the goal is good here, but instead of treating javascript_tag specially, it should probably indent anything within a Ruby do/end block. I'll leave this PR open as a reminder (and because I'll take the tests). |
|
This also needs to ignore tags within tags. Ex <%= javascript_tag nonce: true do %>
fetch('<%= root_url %>/cart.json', ...);
<% end %>gets reformatted to <%= javascript_tag nonce: true do %>
fetch('<%= root_url %>
/cart.json', ...);
<% end %> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allows
<%= javascript_tag %>...<%end>to behave like<script>...</script>I haven't read enough of the whole library to understand the consequences of this PR! It wouldn't surprise me if it is very broken!
Consider this as much a "feature request / issue" as a PR.
... But was easy enough to hack it together so made a PR.
Thanks for your wonderful, relatively lightweight gem.