Skip to content

Commit 98dae6f

Browse files
committed
remove detailed wandb handler from followup config unit tests
1 parent 76c3cd0 commit 98dae6f

File tree

1 file changed

+8
-13
lines changed

1 file changed

+8
-13
lines changed

tests/unit/graph_learning_test.py

+8-13
Original file line numberDiff line numberDiff line change
@@ -907,13 +907,16 @@ def test_reproduce_multiple_episodes(self):
907907
# Check that the arguments for the new experiment are correct
908908
###
909909

910+
# NOTE: detailed wandb logging is currently removed as default. If the handler
911+
# is added back, the handler should be removed in unit tests again. (also in the
912+
# test_reproduce_single_episode_with_multiple_episode_function)
910913
# Detailed wandb logging should be automatically built in, though we will remove
911914
# it to avoid logging tests to wandb
912-
self.assertEqual(
913-
eval_cfg_2["logging_config"]["wandb_handlers"][-1],
914-
DetailedWandbMarkedObsHandler,
915-
)
916-
eval_cfg_2["logging_config"]["wandb_handlers"].pop()
915+
# self.assertEqual(
916+
# eval_cfg_2["logging_config"]["wandb_handlers"][-1],
917+
# DetailedWandbMarkedObsHandler,
918+
# )
919+
# eval_cfg_2["logging_config"]["wandb_handlers"].pop()
917920

918921
# capsule3DSolid is used as the lone eval object; make sure it is listed once
919922
# per episode
@@ -1023,14 +1026,6 @@ def test_reproduce_single_episode_with_multiple_episode_function(self):
10231026
# Check that the arguments for the new experiment are correct
10241027
###
10251028

1026-
# Detailed wandb logging should be automatically built in, though we will remove
1027-
# it to avoid logging tests to wandb
1028-
self.assertEqual(
1029-
eval_cfg_2["logging_config"]["wandb_handlers"][-1],
1030-
DetailedWandbMarkedObsHandler,
1031-
)
1032-
eval_cfg_2["logging_config"]["wandb_handlers"].pop()
1033-
10341029
# check that the object being used is the same one from original exp
10351030
self.assertEqual(
10361031
eval_cfg_1["eval_dataloader_args"].object_names,

0 commit comments

Comments
 (0)