Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figure out why the new flex-grow attribute doesn't work on some blocks #141

Open
jessica-townsend opened this issue Apr 2, 2024 · 1 comment
Assignees

Comments

@jessica-townsend
Copy link
Contributor

Background

We've noticed that on some blocks, the flex-grow attribute doesn't appear on the frontend. We need to investigate where this happens and why. There are a few possibilities:

  • Inside a query loop block
  • On image blocks
  • On blocks that already have a style attribute
@jessica-townsend jessica-townsend self-assigned this Apr 2, 2024
@jessica-townsend
Copy link
Contributor Author

It seems like the issue here is when the flex-grow attribute is used on post-x blocks. Examples include the post-title, post-featured-image, post-author, etc. It might be because the output for these blocks is changed in the render callback function: https://github.com/WordPress/gutenberg/blob/trunk/packages/block-library/src/post-title/index.php#L19

I can look into this further, we might have to use the render block hook instead to filter the block content server-side

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant