Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Get profile temp" should be replaced with an HTTP endpoint #762

Open
thorrak opened this issue Sep 4, 2023 · 0 comments
Open

"Get profile temp" should be replaced with an HTTP endpoint #762

thorrak opened this issue Sep 4, 2023 · 0 comments

Comments

@thorrak
Copy link
Owner

thorrak commented Sep 4, 2023

Although I don't think users have reported it as an issue, given the concern cited in #758 I anticipate that a profile could retrieve an incorrect profile point, similar to how it could log incorrect points. To avoid this possibility, it makes sense to instead retrieve the profile point from an API rather than trying to pull it directly from the database within the fermentrack script caller

https://github.com/thorrak/fermentrack/blob/539050fdc65053f32fddf768f5fa9ea0f23eb726/brewpi-script/fermentrack_config_loader.py#L96C44-L96C44

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant