Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Socket.IO Emit args serialized to string #245

Open
Chalisi opened this issue Jan 9, 2019 · 4 comments · May be fixed by #286
Open

Socket.IO Emit args serialized to string #245

Chalisi opened this issue Jan 9, 2019 · 4 comments · May be fixed by #286

Comments

@Chalisi
Copy link

Chalisi commented Jan 9, 2019 •
edited
Loading

Hello,

While fixing #212 about Websocket send argument only accepting string, ArrayBuffer or Blob (#213), you broke emit Socket.IO API.
Socket.IO emit function accept any number of arguments and any type compare to Websocket.

Thanks
@apatryda-instapage
Copy link

👍 , Please fix this 🙏

@milen-yordanov
Copy link

This issue breaks my usage case. I still have to use the last unaffected version 7.1.0. Please fix.

@viggyfresh viggyfresh linked a pull request Nov 8, 2019 that will close this issue
Open
@gCardinal
Copy link

Just opened an issue with this same problem, #297. Didn't realize there was already an open one.

Could the PR be merged?

@sunsheeppoplar
Copy link

Would love to see this functionality, @thoov, please!

yiochen added a commit to yiochen/mock-socket that referenced this issue Dec 19, 2020
@yiochen
fix thoov#245
9701273
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix normalize-send when sending object data, add test curai/mock-socket
5 participants
@gCardinal @Chalisi @sunsheeppoplar @milen-yordanov @apatryda-instapage