Create an user

[thujohn]

Hi.

Have you planned to add a method for creating a user if he doesn't exist ?

Cordially.

[thomaswelton]

Yeah, I'd want that feature. Few things holding it up.
From the PHPOauthLib repo daviddesberg/PHPoAuthLib#32 I'd want my code to get profile information (which I already have) https://github.com/thomaswelton/laravel-oauth/tree/master/src/Thomaswelton/LaravelOauth/Common/User to be decoupled from my component so I can contribute back to the PHPoAuthLib

Then also, I'm not sure how people would want to use this. Each laravel app may have a different required schema for the users table. Some my require names, emails last name / first name ect.
I'm not sure how I could implement this in a way that would allow people to customize the account creation.

Right now there is an undocumented method. OAuth::associate() that will link the current logged in user to an OAuth provider.

I need to document my recent changes and am then going to tag my first release.
If you're interest I'd suggest you follow this repo, thanks for the interest.

[msurguy]

Thanks for crating the migrations and the rest to make the associate() work! Looking good!

[thomaswelton]

Thanks! I've picked this project back up tonight, working on it right now. Hoping to tag a release soon.

For user creation I'm thinking that I should just provide a simple way for you to get user details. And then allow people to create their own users and associate them using their own app logic. We'll see what we can do for later releases.

[msurguy]

Cool! This is going to be the best oAuth package for Laravel! Signed up for all notifications! Thanks for the great work!

[landjea]

As an alternate opinion : please don't ever do this. I would much prefer that your oAuth package strictly takes care of the oAuth requirements. I will manage my user creation on my own. If you do implement this, please make it an option in the config to disable it.

.....Actually, I would prefer there be no database work at all done by this package, not even during the handshakes. Just token movement / handshakes and that's all. There are plenty of full-swiss-army-knife packages out there that handle authorization AND access control. I could grab one of those if I wanted that. Just oAuth tokens is my preference. :)

[thomaswelton]

I do a agree with you.
This would simplify the package.
And TBH user creation is not hard when using other packages.

I do think it might be handy to provide a unified API to get basic user data to help with user creation. But maybe that should belong in another package.

I just was hoping to make a one click login and creation in laravel super simple.

Anyway I was really pleased to see your PR. And if you want to be a contributor we should chat sometime and open up push access to the repo. But first I/we need to write some tests :)

On 15 Nov 2013, at 23:51, Jean-Guy Landriault [email protected] wrote:

As an alternate opinion : please don't ever do this. I would much prefer that our oAuth package strictly takes care of the oAuth requirements. I will manage my user creation on my own. If you do implement this, please make it an option in the config to disable it.

.....Actually, I would prefer there be no database work at all done by this package, not even during the handshakes. Just token movement / handshakes and that's all. There are plenty of full-swiss-army-knife packages out there that handle authorization AND access control. I could grab one of those if I wanted that. Just oAuth tokens is my preference. :)

—
Reply to this email directly or view it on GitHub.

[landjea]

Sounds good.