Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rtl direction appears to be broken #297

Open
4 tasks done
RoboMagus opened this issue Feb 14, 2024 · 1 comment · May be fixed by #298
Open
4 tasks done

rtl direction appears to be broken #297

RoboMagus opened this issue Feb 14, 2024 · 1 comment · May be fixed by #298

Comments

@RoboMagus
Copy link

My Home Assistant version: 2024.2.1
(I believe this was still working prior to the Feb update, but unsure)

My lovelace configuration method (GUI or yaml): Yaml

What I am doing: Inverting the render direction of a slider

What I expected to happen: The slider to show Right to Left. E.g.:
image

What happened instead: It stays Left to Right

Minimal steps to reproduce:

  - entity: cover.livingroom_curtain_front_right
    name: rechts
  - entity: cover.livingroom_curtain_front_right_inverted
    type: custom:slider-entity-row
    full_row: true
    hide_state: true
    step: 5
    dir: rtl

Error messages from the browser console:
None

Resulting HTML:
(Note that dir here states ltr instead of rtl)

<div class="wrapper">
      <!--?lit$654776852$-->
            <!--?lit$654776852$-->
            <ha-slider labeled="" pin="" ignore-bar-touch="" dir="ltr" class="full" role="presentation"></ha-slider>
      <!--?lit$654776852$-->
      <!--?lit$654776852$-->
</div>

image


By putting an X in the boxes ([X]) below, I indicate that I:

  • Understand that this is a channel for reporting bugs, not a support forum (https://community.home-assistant.io/).
  • Have made sure I am using the latest version of the plugin.
  • Have followed the troubleshooting steps of the "Common Problems" section of https://github.com/thomasloven/hass-config/wiki/Lovelace-Plugins.
  • Understand that leaving one or more boxes unticked or failure to follow the template above may increase the time required to handle my bug-report, or cause it to be closed without further action.
@RoboMagus
Copy link
Author

It appears that this change overrides the ha-slider direction that's set by the slider-entity-row config.

@RoboMagus RoboMagus linked a pull request Apr 6, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant