Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add posibility to invert slider #162

Closed
AlexZ85 opened this issue Nov 9, 2020 · 19 comments
Closed

Add posibility to invert slider #162

AlexZ85 opened this issue Nov 9, 2020 · 19 comments

Comments

@AlexZ85
Copy link

AlexZ85 commented Nov 9, 2020

Scenario:
While some covers report fully closed/open the slider is all the way to the right, other covers report fully closed/open position when the slider is all they way to the left.
In the image below all the covers are fully closed:
image

Adding an option for the slider to be inverted would fix this behaviour.

@dgebhardt
Copy link

Would also love that option!

@ZTHawk
Copy link

ZTHawk commented Aug 20, 2021

I would also like to have this feature. Useful for covers.

@ldsmovil
Copy link

vertical option with invert would be great !

@thomasloven
Copy link
Owner

This sounds like something you should report to the maintainer of your cover integrations.

Say you want to open all your sliders to 1/4. Would you write your automation to set some of them to 25% and some to 75%?

Also, @ldsmovil #126

@ZTHawk
Copy link

ZTHawk commented Oct 26, 2021

The automation would be always for example 25%. Just the UI shall be inverted. Eg: 100% - value: so 25% would be displayed as 75% in the slider.

@AlexZ85
Copy link
Author

AlexZ85 commented Oct 26, 2021

But do you agree that a "slider-inverted: true" would make the picture in the first post correct? So if "Stue" in the image would have the "silder-inverted: true" then, when the cover is fully closed, the slider would be gray and slider knob would be on the left side, aligning with "Jentene", "Ariel" and "Vårt"

@thomasloven
Copy link
Owner

What I'm saying is; if you're seeing what's in the screenshot when the covers are closed, then that's a problem with your covers, because the first two obviously report "closed" as 100%, while the others don't.

That is objectively wrong: https://developers.home-assistant.io/docs/core/entity/cover#platform-properties-to-be-implemented-by-deriving-platform-classes
image

@ZTHawk
Copy link

ZTHawk commented Oct 26, 2021

My covers have a correct implementation where 100 is fully open. But I would like a slider where left being 100 (=open) and right being 0 (=closed). That is my request at least. Maybe creator has the same intention with his request.

@AlexZ85
Copy link
Author

AlexZ85 commented Oct 26, 2021

Yeah you could argue that this is a problem with the covers and the manufacturer, but i also thought that is the point of such integrations, to give the ability to users to use the products in a way that the user is not constrained to the exact specifications of the manufacturer. (like, only using their official app and so on...). As a finishing note, i also use the custom shutter-card and the creator did implement such change, where the percentage 0/100% can be inverted per cover.
image

@thomasloven
Copy link
Owner

Exactly. The integration is supposed to hide all of that from the user such that every cover acts exactly the same way and says 25 % when 25 % open.

@AlexZ85
Copy link
Author

AlexZ85 commented Oct 26, 2021

But that's the request/issue all about that the visualization of the covers does not reflect reality. I understand that this may be an issue with manufacturer and that's why a parameter for inverted slides would correctly show all the slidees to the left / as behaving in the same way. Anyway, i understand if you think this is something not worth implementing / bothering with.

@thomasloven
Copy link
Owner

thomasloven commented Oct 26, 2021

@AlexZ85
Copy link
Author

AlexZ85 commented Oct 26, 2021

Exactly what was requested. Use another card 👍

@AlexZ85 AlexZ85 closed this as completed Oct 26, 2021
@ZTHawk
Copy link

ZTHawk commented Oct 27, 2021

transform does not solve the request at all. It is just making the slider unusable. I think this was just a sarcastic proposal.
What about pullrequest #134? Would that be the solution to this request?

@AlexZ85
Copy link
Author

AlexZ85 commented Oct 28, 2021

yeah, did not even bother with the provided solution. I guess he doesn't see anything wrong and as long that happens, the visualization issue with this card will be broken, so yeah @ZTHawk, don't bother.

@thomasloven
Copy link
Owner

thomasloven commented Oct 28, 2021

I'm just not convinced that hiding the issue fixes it.

Run the following service call:

service: cover.set_cover_position
data:
  position: 10

And see what happens.

If all of your blinds open just a little bit, then the problem may be with slider-entity row.
But everything you tell me indicates that what will happen is that some of your blinds open a little bit, and some will open almost fully.

That is what you should fix.

It's not that "the visualization of the covers does not reflect reality". The visualization exactly reflects Home Assistants view of the reality. If Home Assistant sees the reality wrong, you'll have a lot of other problems down the line and changing the slider would just make those even MORE confusing when you run into them.

@AlexZ85
Copy link
Author

AlexZ85 commented Oct 28, 2021

You are correct, the ones that are "wrong" behave in the exact same opposite way, instead of going to 10% closure they go to to 90%, yes like in the original screenshot they report the opposite of what the others report. That is wrong, i know it, you know it everybody knows it and understands it. That is the root cause.
But! The request was not about fixing the cover so that it reports the correct value, the request is about the slider to report the state according to what we know the reality is. Like in the previous post where I showed the shutter-card, the "invert percentage" parameter is there specifically for cases like this, because the animation for that card would show 100% state as "fully closed" for some where for others, the same percentage would be "fully open". This gives flexibility to the user dor exactly such usecases.
The statement with "talk to the manufacturer so it can fix it" is not optimal because we all know if it would have been that easy we would not need 3rd party integrations, we would just ask all the manufacturers to add support for HomeAssistant and they would do it.
This issue is like, say you have an app with a humidity sensor, a bird pisses on the sensor and the app reports that is raining when it's clearly sunny as hell outside. Is the app wrong? Well according to you is not because it detected humidity that is similar to rain drops based on the velocity of the piss, angle and whatever. The app is showing correct values buttttt still that is not the reality right, it's not raining.A parameter like the one requested would give the user the ability to say "hey if you don't detect raindrops for more than 5 minutes, than yeah you cant say it's raining". Anyway, in the end is about giving the user flexibility and options.

@thomasloven
Copy link
Owner

Then we'll just have to agree to disagree. Slider-entity-row will keep reporting the state in Home Assistant and nothing else.

I'm not asking you to talk to the cover manufacturer about the problem, though. From their point of view, there's probably no problem at all. I'm asking you to talk to whoever made the integration that interprets the reality as a Home Assistant state - be that the Home Assistant team or some third party.
You're probably not the only one with this problem, and they'd likely want their integration to work correctly.

@AlexZ85
Copy link
Author

AlexZ85 commented Oct 28, 2021

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants