-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
READ THIS FIRST! - CARD-MOD 3.4.0 IS NOT WORKING? #332
Comments
@thomasloven |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
Thanks for your continious Work on this awesome Component! Now i would need to add the card_mod Line, and add everywhere manually 2 Spaces for correct indentation. How did you and all handle that, are you using a special RegEx or similar to do that? I would love to avoid those hours of stupid spacebar-hitting... ;-) |
Well. A good editor, like Visual Studio Code (or vim), should let you indent a whole block by selecting it and pressing tab (or >) once. |
In the YAML editors you can select a block of code and hit tab, it will
move the entire block the text indented in (no need to use spacebar or
individual lines). If you need to outdent, you can do a block and use
shift+tab. Vscode is also a great suggestion.
…--
Geoff Hallford
On Sun, Dec 31, 2023, 8:09 AM Thomas Lovén ***@***.***> wrote:
Well. A good editor, like Visual Studio Code
<https://code.visualstudio.com/> (or vim), should let you indent a whole
block by selecting it and pressing tab (or >) once.
That's a start.
—
Reply to this email directly, view it on GitHub
<#332 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEH3ED7AQ3LDGGNNS3YDZ33YMFPZPAVCNFSM6AAAAABBGSDPUKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNZSHE2DKMZRGI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Thanks guys! Im used to notepad++, but since it would take me 3+ hrs to go through everything (even with doing it in blocks), I thought there is maybe a more automated way... Anyway, if there's nothing u guys are aware of, I have some meditational work to do in the morning 😀 |
Hello, I cannot get the new card-mod 3.4.0 working. I use the code:
What ever part do change, nothing happens in the layout of the card. Even if I do copy/paste the lines from the manual in a new card:
Nothing red comes up. Card-mot is installed (actualy:updated).
in th config yaml What do I do wrong? |
@brinkgit |
@brinkgit |
I am not sure if mine is correct, this is my config and since 3.4 (and HA 2024.1) it has stopped working properly. I am not getting the reduced spacing I have been previously getting. My config is not the first one you posted @thomasloven but it is also not the second, it is somewhere in between....
|
No need to post here since it is unrelated to the topic. |
Since it stopped working on this release and the differences in the OP are similar, it looks related to the topic to me.. |
I'm surprised that nobody has mentioned that a major change should be a major version bump, not a minor one. |
Probably because it not a "major change". |
Finaly I found a solution. |
I am not sure that 3.4.1 was the one who gave the trouble, I did not intall 3.4.0. Could have been a problem also in 3.4.0, and that seems to me a more major change |
The change was in a major version bump. |
That's fair going by my original comment, but that's not what I meant. Breaking changes should be signified by major versions, to make it more clear that there was a major change to both users and bots. |
Yes. I admit I should have communicated this more clearly. Sorry. |
I guess that's fair, given that this isn't that big of a problem considering that I don't think HACS or any auto-updaters look at the major version. It's just a mismatch between the semantic versioning spec. |
Just installed 3.4.2 version and my badge didn' t change colors. |
The answer is here: https://github.com/thomasloven/lovelace-card-mod/releases |
Card-mod version 3.4 depreciated an old way to add CSS styles. Having card_mod: above style is now mandatory so this fixes that. More info here on that update here: thomasloven/lovelace-card-mod#332
Card-mod version 3.4 depreciated an old way to add CSS styles. Having card_mod: above style is now mandatory so this fixes that. More info here on that update here: thomasloven/lovelace-card-mod#332
If card-mod 3.4.0 is not working for you, please check your configuration.
has not been the recommended way to do things for more than two years and has been causing trouble since the start, so I didn't think twice about removing it.
If you have that in your configuration, use the following instead:
You know... as it says in the readme.
...which you claim to have re-read when you check the box at the bottom of the issue template:
It's really there to avoid wasting both of our time 😉
The text was updated successfully, but these errors were encountered: