Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stopped working with new IMDB Layout #3

Open
C4rter opened this issue Dec 10, 2022 · 6 comments
Open

Stopped working with new IMDB Layout #3

C4rter opened this issue Dec 10, 2022 · 6 comments

Comments

@C4rter
Copy link

C4rter commented Dec 10, 2022

IMDB did a complete new layout of the actor page now which breaks the script.

I had a look at it but it seems to be that larger parts of the script have to change.

The Json for the birth/death dates information is still there but somehow the birthDate field in that json is not there for everybody.
It works here for example:
https://www.imdb.com/name/nm5232139/?ref_=ls_mv_desc
But not here:
https://www.imdb.com/name/nm0805658/

Identifying the element with the birth/death date to add the current age is also harder now, as the class of that element is something like "sc-dec7a8b-2 bHCQQx" and I don't see any other info to find that element by.

Regarding adding the age of the person to each entry as "Actor", "Producer" etc. (when they were in the film).
These entries are now not all already there anymore, but are loaded via Ajax on the fly. Just a few are loaded directly.
That would require to apply the script on each load of the data to apply the age to these entries.

Do you think you can have a look at the script? It was really useful over the years to me.
Thanks in advance.

@thomasdstewart
Copy link
Owner

thomasdstewart commented Dec 10, 2022 via email

@Prinz23
Copy link

Prinz23 commented Dec 11, 2022

I forked and adapted the script for the new layout: https://github.com/Prinz23/IMDBAge

At least for me it works.

@C4rter
Copy link
Author

C4rter commented Dec 11, 2022

I forked and adapted the script for the new layout: https://github.com/Prinz23/IMDBAge

At least for me it works.

Sweet, thank you. That's awesome. It works for me too.

@C4rter
Copy link
Author

C4rter commented Mar 18, 2023

@Prinz23 I think it stopped working again for the "Actor", "Producer" etc. entries. The age at the top still works but it's missing from the single entries of their work.

@Prinz23
Copy link

Prinz23 commented Mar 18, 2023

Fix in version 2.24, should autoupdate to it if you have a recent version of mine. They simply changed the html field type of the year on the page.

@C4rter
Copy link
Author

C4rter commented Mar 18, 2023

Oh yeah, changed from label to span. Thanks for the fix, got it now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants