Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DatetimeLib usage in energy.geoProcesses.DirectSolarIrradiation.py #6

Open
s-martiz opened this issue Sep 12, 2022 · 0 comments
Open

Comments

@s-martiz
Copy link

I think there is a little code malfunction in DirectSolarIrradiation.py
Indeed, whatever the dtStart, dtStop values (ex: datetime(2021, 12, 21, 6), datetime(2021, 12, 21, 12)), the calculation is done for the entire day. I suggest this change

datetimes = DatetimeLib.range(dtStart, dtStop, dtDelta)
import pandas as pd
datetimes = [x.to_pydatetime() for x in pd.date_range(start=dtStart, end=dtStop, freq=freq, tz='Europe/Paris').tolist()]

@s-martiz s-martiz changed the title little bug in energy.geoProcesses.DirectSolarIrradiation.py DatetimeLib usage in energy.geoProcesses.DirectSolarIrradiation.py Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant