WordPress plugin repo contains .ignore files

[matijamrkaic]

Hi there!

Plugin .zip on WordPress repo contains .gitignore and .svnignore files in its root.
This can lead to some problems with pushing whole site repositories to production. Like this:

PHP Fatal error:  require(): Failed opening required 
'/app-root/data/plugins/wp-less/lib/../vendor/leafo/lessphp/lessc.inc.php'
​ ​... ​  in /app-root/data/plugins/wp-less/lib/Plugin.class.php on line 48​

It might be a good idea to remove them, if that is possible, to skip rare but unnecessary problems.

Cheers!

[thom4parisot]

Hello @matijamrkaic, how do you relate that .gitignore is the cause of this PHP include error?

[matijamrkaic]

.gitignore file contains /vendor/.
When locally developed site is pushed to production with git, it ignores the plugins/wp-less/vendor.
That folder never gets to the production, thus the require() of /wp-less/lib/../vendor/leafo/lessphp/lessc.inc.php fails.

Does this make sense?

[thom4parisot]

Oh yes I see now. vendor is not meant to be versioned though.

Do you use composer?
If so simply do a composer install to pull your dependencies, and version only the composer.json file.
You can register the dependency on wp-less plugin by executing composer require oncletom/wp-less:~1.7.0.

[matijamrkaic]

I will try that out!

[thom4parisot]

Cool. Let me know if more informations are needed. Because it could be useful for #66.

[tordans]

@matijamrkaic did you find a solution for this? What is your current workflow?
I have a similar issue at #76.
Thanks

[matijamrkaic]

Hi @tordans,
After adding the plugin to wp-content/plugins, I simply removed the .ignore files from wp-less folder.

Cheers!

[tordans]

Hi @matijamrkaic but that means you have to do it for each update again, right?
Also: Did you use the wp-admin-plugins page to start the update process or did you download it manually? I used the wp-admin-plugins page (and removed the .ignores afterwards) – which did not work.

Also I tried extending my own .gitignore with wp-content/plugins/**/.gitignore but still got the problem.

I will try downloading the zip and modifying it before adding the content next.

[matijamrkaic]

@tordans,
After each wp-less update, true. But it's not like it's updated daily. Actually I've updated it only once in the past 6 months. And yes, manually.
I always update things on dev repo (, remove .ignore files), and then just push to production.

Also I tried extending my own .gitignore with wp-content/plugins/**/.gitignore but still got the problem.

That is very clever idea. Too bad it fails.

[thom4parisot]

Could you share your deploy script (the relevant bit on how you deploy the plugin)? So as I can understand how you guys are doing it?

Thanks :-)

[thom4parisot]

Have a look to #66 (comment) for hints to install the project without running into the .gitignore issue.