Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

$lessfile_in_theme error on Windows #131

Open
davisctools opened this issue Aug 9, 2022 · 0 comments · May be fixed by #132
Open

$lessfile_in_theme error on Windows #131

davisctools opened this issue Aug 9, 2022 · 0 comments · May be fixed by #132

Comments

@davisctools
Copy link

When using this plugin on a server hosted in Windows, line 88 in lib/Stylesheet.class.php is not able to execute for two reasons:

  1. $this->stylesheet->src returns a url on my machine, which contains '/', but the search term is looking for DIRECTORY_SEPARATOR, which on my machine is \
  2. On a machine where DIRECTORY_SEPARATOR is \, preg_replace won't even be able to run, as the \ characters in the search term aren't escaped.

@pixelbart's pull request #124 largely fixes this issue, but still results in a warning appearing from the unescaped \

I believe this is the same error mentioned by Kari Sharp on the WordPress support forums.
davisctools added a commit to davisctools/wp-less that referenced this issue Aug 9, 2022
@davisctools
Update Stylesheet.class.php
203f2b3 
Fixed thom4parisot#131, as well updated indentation and spacing for consistency.
@davisctools davisctools linked a pull request Aug 9, 2022 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update Stylesheet.class.php davisctools/wp-less
1 participant
@davisctools