Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to GOTOOLCHAIN #119

Open
BenTheElder opened this issue Aug 5, 2024 · 1 comment
Open

Migrate to GOTOOLCHAIN #119

BenTheElder opened this issue Aug 5, 2024 · 1 comment
Assignees

Comments

@BenTheElder
Copy link

We should migrate away from the custom GO_VERSION to the standardized GOTOOLCHAIN (and also stop overriding it in the makefile by default versus telling users to set toolchain in their go.mod, but allow callers to override the module with GOTOOLCHAIN)

I would propose a transition period where GO_VERSION is read if set and a warning is produced while translating it to the GOTOOLCHAIN equivilant.

I've been thinking about how to approach this for kubernetes, one caveat remains that toolchain is per-module if not overridden by the env, versus GO_VERSION right now means the default is a single repo-scoped value (for multi-module repos).

The user overridden GOTOOLCHAIN or GO_VERSION would easily remain repo-scoped, but the default value would not and some diligence is needed to ensure all modules are in sync.

@thockin
Copy link
Owner

thockin commented Aug 12, 2024

PRs welcome - this repo is OK with breaking changes, since it is a template.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants