Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ERC721Base] missing virtual on internal function _msgSender #646

Open
ArthurD1 opened this issue May 10, 2024 · 2 comments
Open

[ERC721Base] missing virtual on internal function _msgSender #646

ArthurD1 opened this issue May 10, 2024 · 2 comments

Comments

@ArthurD1
Copy link

Hello,

I believe we should be able to override this function but it is not marked as virtual.

function _msgSender() internal view override(Multicall, Context) returns (address) {

@Iamalok007
Copy link

It's a valid point that the _msgSender() function should be marked as virtual to allow for easier customization and overrides in derived contracts.I suggest adding the virtual modifier to the _msgSender() function to enable this feature.

@Iamalok007
Copy link

If you could assign this issue to me, I'd be glad to implement the necessary changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants