New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

isAuctionExpired view function is with wrong return value #643

Open

karacurt opened this issue May 5, 2024 · 0 comments

karacurt commented May 5, 2024 •

edited

Loading

The actual function is considering active auctions as expired (if endTimestamp is in the future)

  function isAuctionExpired(uint256 _auctionId) external view onlyExistingAuction(_auctionId) returns (bool) {
        return _englishAuctionsStorage().auctions[_auctionId].endTimestamp >= block.timestamp;
    }

The correct conditional should be to check if endTimestamp is in the past, and then return true for expired.

I opened a PR with the fix here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment