Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drupal 10.1.x JavaScript development now requires Node.js 18 #83

Open
gitressa opened this issue May 8, 2023 · 5 comments
Open

Drupal 10.1.x JavaScript development now requires Node.js 18 #83

gitressa opened this issue May 8, 2023 · 5 comments

Comments

@gitressa
Copy link
Contributor

gitressa commented May 8, 2023

Drupal 10.0 had a minimum version of Node.js 16 for core JavaScript development. Node.js 16 is end of life in September 2023, and so Drupal 10.1 will now require Node.js 18 for core development.

This only affects sites that have installed Drupal core's JavaScript development dependencies with npm or yarn.

From Core JavaScript development now requires Node.js 18.

Task

Update this line from version 16 to 18, and check if anything else needs updating:

- curl -sL https://deb.nodesource.com/setup_16.x | bash -

https://github.com/lando/drupal-contributions/blob/10.x/.lando.yml#L11

@Ankit-Jaipuriar
Copy link

Hi! @gitressa please assign this task to me.

@gitressa
Copy link
Contributor Author

That's not needed. Feel free to go ahead and create a Pull request, thanks!

@Ankit-Jaipuriar
Copy link

Ankit-Jaipuriar commented Aug 13, 2023

@gitressa I am beginner in this field, can u help me about this.
$ git push -u origin ISSUE#83-COMMENT#
ERROR: Permission to lando/drupal-contributions.git denied to Ankit-Jaipuriar.
fatal: Could not read from remote repository.
Please make sure you have the correct access rights
and the repository exists.

@AaronFeledy
Copy link

AaronFeledy commented Aug 13, 2023

Hello @Ankit-Jaipuriar. Thank you for contributing! You can find a helpful guide for contributing to Github projects on this page: https://docs.github.com/en/get-started/quickstart/contributing-to-projects

@Ankit-Jaipuriar
Copy link

Hello @Ankit-Jaipuriar. Thank you for contributing! You can find a helpful guide for contributing to Github projects on this page: https://docs.github.com/en/get-started/quickstart/contributing-to-projects

Thank you for help, I have successfully created PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants