Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't test Composer-changing core patches #35

Open
gitressa opened this issue Feb 6, 2021 · 2 comments
Open

Can't test Composer-changing core patches #35

gitressa opened this issue Feb 6, 2021 · 2 comments

Comments

@gitressa
Copy link
Contributor

gitressa commented Feb 6, 2021

It seems like patches for composer.json and composer.lock don't apply, probably because Drush is added during lando rebuild ... See for example Export configuration YAML strings as multiline where the patch from #64 doesn't apply.

Is it possible to somehow squeeze in application of patches such as this during install, before Drush is installed, with an extra parameter, like lando rebuild -y patch https://www.drupal.org/files/issues/2021-02-05/2844452-64.patch?
@gitressa
Copy link
Contributor Author

gitressa commented Feb 7, 2021

... or perhaps drupal-contributions can check if a patch file is present, and if yes apply it during lando rebuild -y before, Drush is installed?

@gitressa
Copy link
Contributor Author

gitressa commented Mar 4, 2021

A patch like Add new “Content Editor” role to Standard Profile (latest: #24) is also difficult to test, since the patch needs to be applied prior to installation.

@gitressa gitressa mentioned this issue Apr 12, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gitressa