Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Table] support loading and empty data #152

Open
dangbt opened this issue Apr 24, 2021 · 3 comments
Open

[Table] support loading and empty data #152

dangbt opened this issue Apr 24, 2021 · 3 comments
Labels
enhancement New feature or request

Comments

@dangbt
Copy link
Contributor

dangbt commented Apr 24, 2021

No description provided.

@thien-do
Copy link
Owner

Is there an example what do you expect to see when the date is not available yet?

  • Keeping the old state
  • Showing skeleton state (in which case you should pass the length of the rows, I think)

API-wise, I think a "busy" prop should be enough for Loading state. Not sure yet about the empty one.

@lqt93 lqt93 added the enhancement New feature or request label Apr 25, 2021
@dangbt
Copy link
Contributor Author

dangbt commented Apr 26, 2021

example here: https://codepen.io/dangbt/pen/QWdYeLp
if data is empty, we should display a row with text 'No Data' or something
About the state, we need a flag to know the data is fetching: busy or loading

@thien-do
Copy link
Owner

Hm that looks ok to be added

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants