Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download filename issue #75

Open
serjooo opened this issue Jun 2, 2017 · 1 comment
Open

Download filename issue #75

serjooo opened this issue Jun 2, 2017 · 1 comment

Comments

@serjooo
Copy link

serjooo commented Jun 2, 2017

Hello! Great project here first of all very useful!

Second of all, there is a bug that I found where if the file name is a "/" it messes up renaming the file since it doesn't consider it a file name, rather as a path, so when i rename, I get my Documents directory nested in subfolders inside other subfolders with the renamed filename. I think there should be a protection against this.

This happened since I allow my users to download any html page they are on, and if you are getting the file name from the last path component of the URL it usually would see the last path component as a "/". I suggest also an improvement, if you get the response of the URL, I think you can access a property of response.suggestedFilename might be better

@strawherotk
Copy link

Totally agree with @serjooo , hope to see this update soon.
The document mentioned we cannot access the downloaded file name, but didn't mention the reason why?
I hope the author would add this function to the project.
Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants