Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature request: move comments to under pictures #343

Open
imthenachoman opened this issue Jul 28, 2017 · 5 comments
Open

feature request: move comments to under pictures #343

imthenachoman opened this issue Jul 28, 2017 · 5 comments

Comments

@imthenachoman
Copy link

I think it would be nicer if comments were under the picture so viewers/users can see the comments right there and add more if they want. Having to go into the right navigation window to see comments isn't very intuitive.

@imthenachoman
Copy link
Author

I think I might try to do this myself. The code looks pretty straightforward. Fingers crossed.

@imthenachoman
Copy link
Author

So I've been able to figure out how you're rendering comments and I am working on moving them in the code. What I can't figure out is how to save timestamp with the comments and render those too. Any pointers/direction? Just not sure what file to look at.

@imthenachoman
Copy link
Author

On am unrelated note, I am going to call all my judgement type classes Judge. Love your comment for that. :)

@imthenachoman
Copy link
Author

scratch that; I saw that you already include timestamp. my bad. having tricky figuring out how you update the comments display after the user presses submit. I see the form but I don't see where you refresh the page or make any HTML update...

@imthenachoman
Copy link
Author

So far I've been able to figure out how to make the following changes:

  • add date/time stamp to comments
  • allow for a custom date format
  • print breadcrumb links in the header so you have another place to see what folder path you're in and to jump to a parent directory

I figured out how to move the comments from Infos.php to Board.php but so far it only works for the main view. I am trying to get it to work when you're in a picture or video. I didn't realize this earlier but clicking on an image or video doesn't reload the page, it uses JS to show the image. Either way, I figured out how to hide the Board.php comments when an item is clicked but I can't figure out how to enable vertical scrolling so I can add the comments to the bottom below the linear panel...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant