endYear column missing in database export

[SAuroux]

as the title says, the 'endYear' column from the Competitions table is not included in the database export. More generally, it might also be a good idea to also include the internal 'start_date' and 'end_date' columns when already fixing this.

[AlbertoPdRF]

Is this issue still relevant? According to this and unless I'm missing something, I believe all columns that you mentioned should be included on the export.

[EdHollingdale]

It is not included in the .tsv export at least. The Competitions export does not have endYear. The only problem this causes is for Welcome to 2019 to the best of my knowledge. The TSV export contains:
id name cityName countryId information year month day endMonth endDay eventSpecs wcaDelegate organiser venue venueAddress venueDetails external_website cellName latitude longitude

[jfly]

I believe this issue is referring to our "public database export", not our "developer's database export" (see https://github.com/thewca/worldcubeassociation.org/wiki/Developer-database-export for more information about why they both exist).

Here's the relevant code for the public database export:

worldcubeassociation.org/webroot/results/admin/export_public.php

Line 61 in fd5a534

Competitions.month, Competitions.day, Competitions.endMonth, Competitions.endDay, replace(GROUP_CONCAT(DISTINCT competition_events.event_id), ",", " ") as eventSpecs,

. If we change this, it's important to make sure that we don't break the WCA workbook assistant (it has hardcoded the order of the various columns in the database export 😢 https://github.com/thewca/wca-workbook-assistant/blob/389e40275a84fc28f137a33d38ed2ccf101e4e45/src/main/java/org/worldcubeassociation/db/WCADatabaseExportDecoder.java#L101-L120)

[AlbertoPdRF]

Yep, I got it wrong. So, it seems we have two options here:

1. Fix this and update the WA code to reflect the changes
2. Only fix this when the WA doesn't exist anymore 😛

As we should release a new version of the WA soon (see this) and option 2 seems too extreme anyway, I think we should go ahead with 1 and fix this now.

[gregorbg]

Reading "option 2 seems too extreme anyway" in 2021 really makes me smile :D

[gregorbg]

Whoops, didn't mean to close this. Sorry! It can be implemented now, because there are no more parts in the WCA toolchain that rely on column order of the public export