Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cd: consider replacing 3rd-party GitHub actions #1967

Open
lukpueh opened this issue Apr 21, 2022 · 0 comments
Open

cd: consider replacing 3rd-party GitHub actions #1967

lukpueh opened this issue Apr 21, 2022 · 0 comments
Labels

Comments

@lukpueh
Copy link
Member

lukpueh commented Apr 21, 2022

Description of issue or feature request:
#1946 adds a CD workflow to release build artifacts on PyPI and GH upon successful completion of the CI workflow for a pushed release tag.

The PR adds 3rd-party actions softprops/action-gh-release and pypa/gh-action-pypi-publish, which goes against our "only allow actions created by GitHub"-policy. It does not seem like a big deal, because the former action is popular and recommended by the archived GitHub-native action/create-release, and the latter is hosted by the PyPA, which also hosts twine, the tool we usually use to publish on PyPI.

We could at least see how hard it would be to implement the required logic for those actions ourselves

Current behavior:
cd.yml uses 3rd-party GitHub actions

Expected behavior:
Assess required effort to replace 3rd-party GitHub actions with custom code, e.g. a shell script that runs twine for pypi uplaod, and a github script that uses octokit to create a release (see custom finalize release action for inspiration for the latter).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant