Skip to content

Split Updater into logical components: bundle metadata #1308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sechkova opened this issue Mar 12, 2021 · 2 comments
Closed

Split Updater into logical components: bundle metadata #1308

sechkova opened this issue Mar 12, 2021 · 2 comments
Assignees
Labels
experimental-client Items related to the development of a new client (see milestone/8 and theexperimental-client branch)

Comments

@sechkova
Copy link
Contributor

I think this the right time to try splitting the Updater functionality into meaningful components -- the Metadata API does a good bit of that already but I think Updater is still going to be too large and should be split if possible (and I think it is possible, also tuf-on-a-plane has some useful ideas). Listing some Updater functionality below for inspiration:

  • implement the TUF update process in a way that is easy to follow and verify
  • keep track of currently valid set of metadata, verify new metadata
  • read/write local metadata files
  • traverse target delegation tree
  • download metadata/target files, while handling mirrors

To me tracking the currently valid set of metadata is one potentially separate thing here: an object could hold the currently valid set of metadata (and verify new metadata and maybe handle reading/writing the local metadata cache) without knowing about all the steps that the TUF spec requires or about the API that Updater wants to provide. Maybe this leads to most code being in the metadata handler but this might be worth testing -- it's also something a bit like what @trishankatdatadog did in tuf-on-a-plane (Repository vs models,writers,readers).

Originally posted by @jku in #1291 (comment)

@sechkova sechkova added the experimental-client Items related to the development of a new client (see milestone/8 and theexperimental-client branch) label Mar 12, 2021
@sechkova sechkova added this to the Client Refactor milestone Mar 12, 2021
@sechkova sechkova self-assigned this Mar 15, 2021
@sechkova sechkova mentioned this issue Apr 8, 2021
3 tasks
@sechkova
Copy link
Contributor Author

To be fixed by #1355

@jku
Copy link
Member

jku commented May 19, 2021

Closing:

  • MetadataBundle is merged (if not quite in use yet)
  • download handling is a lot better separated now that mirrors are gone

Further changes in components can be done incrementally:

  • maybe we want to separate Updater and target caching
  • maybe we want to separate graph traversal and the Updater

@jku jku closed this as completed May 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
experimental-client Items related to the development of a new client (see milestone/8 and theexperimental-client branch)
Projects
None yet
Development

No branches or pull requests

3 participants