Skip to content

Commit 4bfd889

Browse files
committed
[client rework]: Fix various pylint issues
Fix linter issues after applying the api/pylintrc config. Signed-off-by: Teodora Sechkova <[email protected]>
1 parent cf5a59c commit 4bfd889

File tree

2 files changed

+102
-65
lines changed

2 files changed

+102
-65
lines changed

tuf/client_rework/metadata_wrapper.py

+8-7
Original file line numberDiff line numberDiff line change
@@ -25,18 +25,19 @@ def __init__(self, meta):
2525
def from_json_object(cls, tmp_file):
2626
"""Loads JSON-formatted TUF metadata from a file object."""
2727
raw_data = tmp_file.read()
28-
28+
# Use local scope import to avoid circular import errors
29+
# pylint: disable=import-outside-toplevel
2930
from tuf.api.serialization.json import JSONDeserializer
3031

3132
deserializer = JSONDeserializer()
32-
_meta = deserializer.deserialize(raw_data)
33-
return cls(meta=_meta)
33+
meta = deserializer.deserialize(raw_data)
34+
return cls(meta=meta)
3435

3536
@classmethod
3637
def from_json_file(cls, filename):
3738
"""Loads JSON-formatted TUF metadata from a file."""
38-
_meta = metadata.Metadata.from_file(filename)
39-
return cls(meta=_meta)
39+
meta = metadata.Metadata.from_file(filename)
40+
return cls(meta=meta)
4041

4142
@property
4243
def signed(self):
@@ -97,7 +98,7 @@ def keys(self, role):
9798
keys = []
9899
for keyid in self._meta.signed.roles[role]["keyids"]:
99100
key_metadata = self._meta.signed.keys[keyid]
100-
key, _ = format_metadata_to_key(key_metadata)
101+
key, dummy = format_metadata_to_key(key_metadata)
101102
keys.append(key)
102103

103104
return keys
@@ -162,7 +163,7 @@ def keys(self, role):
162163
if delegation["name"] == role:
163164
for keyid in delegation["keyids"]:
164165
key_metadata = self._meta.signed.delegations["keys"][keyid]
165-
key, _ = format_metadata_to_key(key_metadata)
166+
key, dummy = format_metadata_to_key(key_metadata)
166167
keys.append(key)
167168
return keys
168169

0 commit comments

Comments
 (0)