Skip to content

Commit 0285bf9

Browse files
authored
Merge pull request #1731 from jku/ngclient-arg-rename
ngclient: Rename constructor arg
2 parents 551a10c + 2a6e773 commit 0285bf9

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

examples/client_example/client_example.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ def download(target: str) -> bool:
5252
"""
5353
try:
5454
updater = Updater(
55-
repository_dir=METADATA_DIR,
55+
metadata_dir=METADATA_DIR,
5656
metadata_base_url=f"{BASE_URL}/metadata/",
5757
target_base_url=f"{BASE_URL}/targets/",
5858
target_dir=DOWNLOAD_DIR,

tests/test_updater_ng.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,7 @@ def setUp(self) -> None:
128128
# Creating a repository instance. The test cases will use this client
129129
# updater to refresh metadata, fetch target files, etc.
130130
self.updater = ngclient.Updater(
131-
repository_dir=self.client_directory,
131+
metadata_dir=self.client_directory,
132132
metadata_base_url=self.metadata_url,
133133
target_dir=self.dl_dir,
134134
target_base_url=self.targets_url,

tuf/ngclient/updater.py

+4-4
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@
4545
# Load trusted local root metadata from client metadata cache. Define
4646
# where metadata and targets will be downloaded from.
4747
updater = Updater(
48-
repository_dir="~/tufclient/metadata/",
48+
metadata_dir="~/tufclient/metadata/",
4949
metadata_base_url="http://localhost:8000/tuf-repo/",
5050
target_dir="~/tufclient/downloads/",
5151
target_base_url="http://localhost:8000/targets/",
@@ -87,7 +87,7 @@ class Updater:
8787
"""Creates a new Updater instance and loads trusted root metadata.
8888
8989
Args:
90-
repository_dir: Local metadata directory. Directory must be
90+
metadata_dir: Local metadata directory. Directory must be
9191
writable and it must contain a trusted root.json file.
9292
metadata_base_url: Base URL for all remote metadata downloads
9393
target_dir: Local targets directory. Directory must be writable. It
@@ -105,14 +105,14 @@ class Updater:
105105

106106
def __init__(
107107
self,
108-
repository_dir: str,
108+
metadata_dir: str,
109109
metadata_base_url: str,
110110
target_dir: Optional[str] = None,
111111
target_base_url: Optional[str] = None,
112112
fetcher: Optional[FetcherInterface] = None,
113113
config: Optional[UpdaterConfig] = None,
114114
):
115-
self._dir = repository_dir
115+
self._dir = metadata_dir
116116
self._metadata_base_url = _ensure_trailing_slash(metadata_base_url)
117117
self.target_dir = target_dir
118118
if target_base_url is None:

0 commit comments

Comments
 (0)