Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[regression] daily stable v2.2 shows regression across multiple boards #5321

Open
ujfalusi opened this issue Feb 6, 2025 · 2 comments
Open
Assignees
Labels
bug Something isn't working sof v2.2.2 Bugs observed with SOF v2.2.2

Comments

@ujfalusi
Copy link
Collaborator

ujfalusi commented Feb 6, 2025

There is a clear regression happened after merging #5262
49350 test run is clean, before merging it
49411 failures across multiple boards

The changes between the two tests in kernel:

e2b6395070e8 ASoC: SOF: ipc4-topology: Remove the skip_during_fe_trigger flag
45e374d0e139 ASoC: SOF: Refactor pipeline management
9232c227d9ab drivers: soundwire: Add new prepare op in struct sdw_intel_ops
962f8bbd7468 ASoC: SOF: sof-audio: Add helper functions for BE managed pipelines
f14ac2b9dc4f ASoC: SOF: pcm: Split up widget prepare and setup
259fa001dbaa ASoC: SOF: sof-audio: Add a new op in struct sof_ipc_tplg_ops

The PR test for stable v2.2 was clean.

@ranj063, @kv2019i, @bardliao, if we cannot fix this fast we should revert #5262 and rework it.

@ujfalusi ujfalusi added bug Something isn't working sof v2.2.2 Bugs observed with SOF v2.2.2 labels Feb 6, 2025
@ujfalusi
Copy link
Collaborator Author

ujfalusi commented Feb 6, 2025

bisected to
f14ac2b ("ASoC: SOF: pcm: Split up widget prepare and setup")

@ujfalusi
Copy link
Collaborator Author

ujfalusi commented Feb 6, 2025

It looks like that the use_count for widgets are incrementing.

Running

TPLG=/lib/firmware/intel/sof-tplg/sof-hda-generic.tplg SOF_TEST_INTERVAL=5 ~/sof-test/test-case/check-signal-stop-start.sh -m playback -c 20

and stopping after the 12th iteration is started with ctrl-c:

[23309.423813] sof-audio-pci-intel-tgl 0000:00:1f.3: sof_ipc3_tear_down_all_pipelines: widget PIPELINE.30.HDA0.OUT is still in use: count 4
[23309.423826] sof-audio-pci-intel-tgl 0000:00:1f.3: sof_ipc3_tear_down_all_pipelines: widget BUF30.1 is still in use: count 12
[23309.423830] sof-audio-pci-intel-tgl 0000:00:1f.3: sof_ipc3_tear_down_all_pipelines: widget BUF30.0 is still in use: count 12
[23309.423833] sof-audio-pci-intel-tgl 0000:00:1f.3: sof_ipc3_tear_down_all_pipelines: widget PGA30.0 is still in use: count 12
[23309.423837] sof-audio-pci-intel-tgl 0000:00:1f.3: sof_ipc3_tear_down_all_pipelines: widget PCM0P is still in use: count 12
[23309.423841] sof-audio-pci-intel-tgl 0000:00:1f.3: sof_ipc3_tear_down_all_pipelines: widget BUF1.1 is still in use: count 12
[23309.423844] sof-audio-pci-intel-tgl 0000:00:1f.3: sof_ipc3_tear_down_all_pipelines: widget BUF1.0 is still in use: count 12
[23309.423847] sof-audio-pci-intel-tgl 0000:00:1f.3: sof_ipc3_tear_down_all_pipelines: widget PIPELINE.1.HDA0.OUT is still in use: count 5
[23309.423851] sof-audio-pci-intel-tgl 0000:00:1f.3: sof_ipc3_tear_down_all_pipelines: widget HDA0.OUT is still in use: count 12
[23309.423855] sof-audio-pci-intel-tgl 0000:00:1f.3: sof_ipc3_tear_down_all_pipelines: widget PGA1.0 is still in use: count 12
[23309.423857] sof-audio-pci-intel-tgl 0000:00:1f.3: sof_ipc3_tear_down_all_pipelines: widget MIXER1.0 is still in use: count 12

@ujfalusi ujfalusi changed the title [regression] daily stable v2.2 shows major regression across multiple boards [regression] daily stable v2.2 shows regression across multiple boards Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working sof v2.2.2 Bugs observed with SOF v2.2.2
Projects
None yet
Development

No branches or pull requests

2 participants