Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REST GET requests are discarding the parameters #252

Open
cetetesoft opened this issue Oct 9, 2021 · 0 comments
Open

REST GET requests are discarding the parameters #252

cetetesoft opened this issue Oct 9, 2021 · 0 comments

Comments

@cetetesoft
Copy link

cetetesoft commented Oct 9, 2021

The AbstractRestRequest::sendData() method is building the URL for GET requests like so:
$requestUrl = $this->getEndpoint() . '?' . http_build_query($data);
But this URL is used nowhere after this. Instead, the request is using $this->getEndpoint() as the URL.

This:

            $httpResponse = $this->httpClient->request(
                $this->getHttpMethod(),
                $this->getEndpoint(),

Should be replaced with:

            $httpResponse = $this->httpClient->request(
                $this->getHttpMethod(),
                $requestUrl,
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant