Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Events and add TODOs for the next major release #1467

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix Events and add TODOs for the next major release #1467

wants to merge 2 commits into from

Conversation

hafezdivandari
Copy link
Contributor

Related to #1465

  • Fixed a bug where "Device Authorization" grant emits wrong events after access / refresh token is issued.
  • No event is emitted on "Implicit" grant after an access token is issued, unlike other grants!
    • This can't be fixed without changing the method signature which is a BC breaking change.
    • Added a TODO comment to be fixed on the next major release.
  • Added a TODO comment to fix a typo on the argument name of the \League\OAuth2\Server\Repositories\DeviceCodeRepositoryInterface::getDeviceCodeEntityByDeviceCode() method on the next major release: string $deviceCodeEntity -> string $deviceCode

@hafezdivandari hafezdivandari mentioned this pull request Dec 10, 2024
Open
Sephster
Sephster requested changes Dec 20, 2024
View reviewed changes
Copy link
Member

@Sephster Sephster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @hafezdivandari and thanks for your ongoing work with the library. Would it be possible to add a test for the event emissions and a changelog entry? If you don't have time I can take a look at this. Thank you

@Sephster Sephster linked an issue Dec 20, 2024 that may be closed by this pull request
implicit flow doesn't emit RequestEvent::ACCESS_TOKEN_ISSUED #1465
Open
@hafezdivandari
Copy link
Contributor Author

hafezdivandari commented Dec 20, 2024 •
edited
Loading

Sure @Sephster I'll complete this asap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sephster Sephster Sephster requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

implicit flow doesn't emit RequestEvent::ACCESS_TOKEN_ISSUED
2 participants
@hafezdivandari @Sephster