Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trello "An unknown application" #137

Open
alegag opened this issue Jul 29, 2021 · 2 comments
Open

Trello "An unknown application" #137

alegag opened this issue Jul 29, 2021 · 2 comments

Comments

@alegag
Copy link

alegag commented Jul 29, 2021

Calling the class with parameter name don't seems to apply it to Trello.

$Trello = new Trello([
            'identifier' => c('TRELLO_KEY'),
            'secret' => c('TRELLO_SECRET'),
            'callback_uri' => Http::url(),
            'name' => c('APP_NAME'),
            'expiration' => 'never',
            'scope' => 'read,write'
        ]);

The value of APP_NAME get passed in the URL, but the result on the Trello auth-page is "An unknown application" instead of the expected value.

@alegag
Copy link
Author

alegag commented Jul 29, 2021

Turns out the length should be at least 5-chars (not documented on Trello side either, discovered by trial-and-error).

Should the Trello class throw an exception if name length is <=4 chars ? What do you think ? (I can do an MR for it if the proposition makes sense)

@bencorlett
Copy link
Member

I'm not sure if this should be this package's responsibility to validate that, especially if it's not documented. However, if you would like to consider it, please

Also please note that Trello is not included as an out of the box provider in V2, however integrating custom providers is easy there.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants